SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hw/core/generic-loader: Allow PC to be set on command line

Browse Source 
The documentation for the generic loader claims that you can
set the PC for a CPU with an option of the form
  -device loader,cpu-num=0,addr=0x10000004

However if you try this QEMU complains:
  cpu_num must be specified when setting a program counter

This is because we were testing against 0 rather than CPU_NONE.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180205150426.20542-1-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2018-02-05 15:04:26 +00:00
parent 384c6c03fb
commit bbba7757ba
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/core/generic-loader.c
View File

@ -105,7 +105,7 @@ static void generic_loader_realize(DeviceState *dev, Error **errp)
error_setg(errp, "data can not be specified when setting a " error_setg(errp, "data can not be specified when setting a "
"program counter"); "program counter");
return; return;
} else if (!s->cpu_num) { } else if (s->cpu_num == CPU_NONE) {
error_setg(errp, "cpu_num must be specified when setting a " error_setg(errp, "cpu_num must be specified when setting a "
"program counter"); "program counter");
return; return;