SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

sm501: Use stn_he_p/ldn_he_p instead of switch/case

Browse Source 
Instead of open coding op with different sizes using a switch and type
casting it can be written more compactly using stn_he_p/ldn_he_p.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: e2f649cb286f0735a10ec87c1b36a7ae081acb61.1592686588.git.balaton@eik.bme.hu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
BALATON Zoltan 2020-06-20 22:56:28 +02:00 committed by Gerd Hoffmann
parent c208085a3e
commit ba27110fab
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hw/display/sm501.c
View File

@ -766,17 +766,7 @@ static void sm501_2d_operation(SM501State *s)
for (y = 0; y < height; y++) { for (y = 0; y < height; y++) {
i = (dst_x + (dst_y + y) * dst_pitch) * bypp; i = (dst_x + (dst_y + y) * dst_pitch) * bypp;
for (x = 0; x < width; x++, i += bypp) { for (x = 0; x < width; x++, i += bypp) {
switch (format) { stn_he_p(&d[i], bypp, ~ldn_he_p(&d[i], bypp));
case 0:
d[i] = ~d[i];
break;
case 1:
*(uint16_t *)&d[i] = ~*(uint16_t *)&d[i];
break;
case 2:
*(uint32_t *)&d[i] = ~*(uint32_t *)&d[i];
break;
}
} }
} }
} else { } else {