SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

vfio/ap: Use g_autofree variable in vfio_ap_register_irq_notifier()

Browse Source 
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
This commit is contained in:
Cédric Le Goater 2024-04-25 11:02:11 +02:00
parent 33dc04b072
commit ae7aca14bd
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hw/vfio/ap.c
View File

@ -77,7 +77,7 @@ static void vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
size_t argsz; size_t argsz;
IOHandler *fd_read; IOHandler *fd_read;
EventNotifier *notifier; EventNotifier *notifier;
struct vfio_irq_info *irq_info; g_autofree struct vfio_irq_info *irq_info = NULL;
VFIODevice *vdev = &vapdev->vdev; VFIODevice *vdev = &vapdev->vdev;
switch (irq) { switch (irq) {
@ -104,14 +104,14 @@ static void vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
if (ioctl(vdev->fd, VFIO_DEVICE_GET_IRQ_INFO, if (ioctl(vdev->fd, VFIO_DEVICE_GET_IRQ_INFO,
irq_info) < 0 || irq_info->count < 1) { irq_info) < 0 || irq_info->count < 1) {
error_setg_errno(errp, errno, "vfio: Error getting irq info"); error_setg_errno(errp, errno, "vfio: Error getting irq info");
goto out_free_info; return;
} }
if (event_notifier_init(notifier, 0)) { if (event_notifier_init(notifier, 0)) {
error_setg_errno(errp, errno, error_setg_errno(errp, errno,
"vfio: Unable to init event notifier for irq (%d)", "vfio: Unable to init event notifier for irq (%d)",
irq); irq);
goto out_free_info; return;
} }
fd = event_notifier_get_fd(notifier); fd = event_notifier_get_fd(notifier);
@ -122,10 +122,6 @@ static void vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
qemu_set_fd_handler(fd, NULL, NULL, vapdev); qemu_set_fd_handler(fd, NULL, NULL, vapdev);
event_notifier_cleanup(notifier); event_notifier_cleanup(notifier);
} }
out_free_info:
g_free(irq_info);
} }
static void vfio_ap_unregister_irq_notifier(VFIOAPDevice *vapdev, static void vfio_ap_unregister_irq_notifier(VFIOAPDevice *vapdev,