SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tests/functional/qemu_test/decorators: Fix bad check for imports

Browse Source 
skipIfMissingImports should use importlib.import_module() for checking
whether a module with the name stored in the "impname" variable is
available or not, otherwise the code tries to import a module with
the name "impname" instead.
(This bug hasn't been noticed before since there is another issue
with this decorator that will be fixed by the next patch)

Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20250122134315.1448794-2-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Thomas Huth 2025-01-22 14:43:13 +01:00
parent 871af84dd5
commit aca2c48e4d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/functional/qemu_test/decorators.py
View File

@ -2,6 +2,7 @@
# #
# Decorators useful in functional tests # Decorators useful in functional tests
import importlib
import os import os
import platform import platform
from unittest import skipUnless from unittest import skipUnless
@ -97,7 +98,7 @@ def skipIfMissingImports(*args):
def has_imports(importlist): def has_imports(importlist):
for impname in importlist: for impname in importlist:
try: try:
import impname importlib.import_module(impname)
except ImportError: except ImportError:
return False return False
return True return True