SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

9pfs: Fix some return statements in the synth backend

Browse Source 
The qemu_v9fs_synth_mkdir() and qemu_v9fs_synth_add_file() functions
currently return a positive errno value on failure. This causes
checkpatch.pl to spit several errors like the one below:

ERROR: return of an errno should typically be -ve (return -EAGAIN)
+        return EAGAIN;

Simply change the sign. This has no consequence since callers
assert() the returned value to be equal to 0.

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <166930551818.827792.10663674346122681963.stgit@bahia>
[C.S.: - Resolve conflict with 66997c42e02c. ]
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
This commit is contained in:
Greg Kurz 2022-11-24 16:58:38 +01:00 committed by Christian Schoenebeck
parent 222059a0fc
commit ab04d2c557
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hw/9pfs/9p-synth.c
View File

@ -75,10 +75,10 @@ int qemu_v9fs_synth_mkdir(V9fsSynthNode *parent, int mode,
V9fsSynthNode *node, *tmp; V9fsSynthNode *node, *tmp;
if (!synth_fs) { if (!synth_fs) {
return EAGAIN; return -EAGAIN;
} }
if (!name || (strlen(name) >= NAME_MAX)) { if (!name || (strlen(name) >= NAME_MAX)) {
return EINVAL; return -EINVAL;
} }
if (!parent) { if (!parent) {
parent = &synth_root; parent = &synth_root;
@ -86,7 +86,7 @@ int qemu_v9fs_synth_mkdir(V9fsSynthNode *parent, int mode,
QEMU_LOCK_GUARD(&synth_mutex); QEMU_LOCK_GUARD(&synth_mutex);
QLIST_FOREACH(tmp, &parent->child, sibling) { QLIST_FOREACH(tmp, &parent->child, sibling) {
if (!strcmp(tmp->name, name)) { if (!strcmp(tmp->name, name)) {
return EEXIST; return -EEXIST;
} }
} }
/* Add the name */ /* Add the name */
@ -106,10 +106,10 @@ int qemu_v9fs_synth_add_file(V9fsSynthNode *parent, int mode,
V9fsSynthNode *node, *tmp; V9fsSynthNode *node, *tmp;
if (!synth_fs) { if (!synth_fs) {
return EAGAIN; return -EAGAIN;
} }
if (!name || (strlen(name) >= NAME_MAX)) { if (!name || (strlen(name) >= NAME_MAX)) {
return EINVAL; return -EINVAL;
} }
if (!parent) { if (!parent) {
parent = &synth_root; parent = &synth_root;
@ -118,7 +118,7 @@ int qemu_v9fs_synth_add_file(V9fsSynthNode *parent, int mode,
QEMU_LOCK_GUARD(&synth_mutex); QEMU_LOCK_GUARD(&synth_mutex);
QLIST_FOREACH(tmp, &parent->child, sibling) { QLIST_FOREACH(tmp, &parent->child, sibling) {
if (!strcmp(tmp->name, name)) { if (!strcmp(tmp->name, name)) {
return EEXIST; return -EEXIST;
} }
} }
/* Add file type and remove write bits */ /* Add file type and remove write bits */