SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tests/functional/asset: Fail assert fetch when retries are exceeded

Browse Source 
Currently the fetch code does not fail gracefully when retry limit is
exceeded, it just falls through the loop with no file, which ends up
hitting other errors.

Add a check for non-existing file, which indicates the retry limit was
exceeded.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Message-ID: <20250312130002.945508-2-npiggin@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Nicholas Piggin 2025-03-12 23:00:00 +10:00 committed by Thomas Huth
parent 15ef93dd48
commit a5e8299d1a
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/functional/qemu_test/asset.py
View File

@ -138,6 +138,9 @@ class Asset:
tmp_cache_file.unlink() tmp_cache_file.unlink()
raise raise
if not os.path.exists(tmp_cache_file):
raise Exception("Retries exceeded downloading %s", self.url)
try: try:
# Set these just for informational purposes # Set these just for informational purposes
os.setxattr(str(tmp_cache_file), "user.qemu-asset-url", os.setxattr(str(tmp_cache_file), "user.qemu-asset-url",