SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

rbd: Close image in qemu_rbd_open() error path

Browse Source 
Commit e2b8247a322 introduced an error path in qemu_rbd_open() after
calling rbd_open(), but neglected to close the image again in this error
path. The error path should contain everything that the regular close
function qemu_rbd_close() contains.

This adds the missing rbd_close() call.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Kevin Wolf 2018-10-18 15:17:26 +02:00
parent e35bdc123a
commit a51b9c4862
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
block/rbd.c
View File

@ -787,6 +787,7 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict *options, int flags,
"automatically marking the image read-only."); "automatically marking the image read-only.");
r = bdrv_set_read_only(bs, true, &local_err); r = bdrv_set_read_only(bs, true, &local_err);
if (r < 0) { if (r < 0) {
rbd_close(s->image);
error_propagate(errp, local_err); error_propagate(errp, local_err);
goto failed_open; goto failed_open;
} }