SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

linux-user/i386: Return boolean success from xrstor_sigcontext

Browse Source 
Invert the sense of the return value and use bool.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2024-04-08 13:15:03 -10:00
parent c536f9b77c
commit 9e9b7d4c15
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
linux-user/i386/signal.c
View File

@ -530,7 +530,7 @@ give_sigsegv:
force_sigsegv(sig); force_sigsegv(sig);
} }
static int xrstor_sigcontext(CPUX86State *env, X86LegacyXSaveArea *fxsave, static bool xrstor_sigcontext(CPUX86State *env, X86LegacyXSaveArea *fxsave,
abi_ulong fxsave_addr) abi_ulong fxsave_addr)
{ {
struct target_fpx_sw_bytes *sw = (void *)&fxsave->sw_reserved; struct target_fpx_sw_bytes *sw = (void *)&fxsave->sw_reserved;
@ -549,19 +549,19 @@ static int xrstor_sigcontext(CPUX86State *env, X86LegacyXSaveArea *fxsave,
&& extended_size >= minimum_size) { && extended_size >= minimum_size) {
if (!access_ok(env_cpu(env), VERIFY_READ, fxsave_addr, if (!access_ok(env_cpu(env), VERIFY_READ, fxsave_addr,
extended_size - TARGET_FPSTATE_FXSAVE_OFFSET)) { extended_size - TARGET_FPSTATE_FXSAVE_OFFSET)) {
return 1; return false;
} }
magic2 = tswapl(*(uint32_t *)((void *)fxsave + xstate_size)); magic2 = tswapl(*(uint32_t *)((void *)fxsave + xstate_size));
if (magic2 == TARGET_FP_XSTATE_MAGIC2) { if (magic2 == TARGET_FP_XSTATE_MAGIC2) {
cpu_x86_xrstor(env, fxsave_addr, -1); cpu_x86_xrstor(env, fxsave_addr, -1);
return 0; return true;
} }
} }
/* fall through to fxrstor */ /* fall through to fxrstor */
} }
cpu_x86_fxrstor(env, fxsave_addr); cpu_x86_fxrstor(env, fxsave_addr);
return 0; return true;
} }
static bool restore_sigcontext(CPUX86State *env, struct target_sigcontext *sc) static bool restore_sigcontext(CPUX86State *env, struct target_sigcontext *sc)
@ -629,11 +629,11 @@ static bool restore_sigcontext(CPUX86State *env, struct target_sigcontext *sc)
cpu_x86_frstor(env, fpstate_addr, 1); cpu_x86_frstor(env, fpstate_addr, 1);
ok = true; ok = true;
} else { } else {
ok = !xrstor_sigcontext(env, &fpstate->fxstate, ok = xrstor_sigcontext(env, &fpstate->fxstate,
fpstate_addr + TARGET_FPSTATE_FXSAVE_OFFSET); fpstate_addr + TARGET_FPSTATE_FXSAVE_OFFSET);
} }
#else #else
ok = !xrstor_sigcontext(env, fpstate, fpstate_addr); ok = xrstor_sigcontext(env, fpstate, fpstate_addr);
#endif #endif
unlock_user_struct(fpstate, fpstate_addr, 0); unlock_user_struct(fpstate, fpstate_addr, 0);