SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hw/core/machine-smp: Initialize caches_bitmap before reading

Browse Source 
The caches_bitmap is defined in machine_parse_smp_cache(), but it was
not initialized.

Initialize caches_bitmap by clearing all its bits to zero.

Resolves: Coverity CID 1565389
Fixes: 4e88e7e3403d ("qapi/qom: Define cache enumeration and properties for machine")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Link: https://lore.kernel.org/r/20241110150901.130647-2-zhao1.liu@intel.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Zhao Liu 2024-11-10 23:09:00 +08:00 committed by Paolo Bonzini
parent 19d542cc0b
commit 9c2644948c
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hw/core/machine-smp.c
View File

@ -290,6 +290,7 @@ bool machine_parse_smp_cache(MachineState *ms,
const SmpCachePropertiesList *node; const SmpCachePropertiesList *node;
DECLARE_BITMAP(caches_bitmap, CACHE_LEVEL_AND_TYPE__MAX); DECLARE_BITMAP(caches_bitmap, CACHE_LEVEL_AND_TYPE__MAX);
bitmap_zero(caches_bitmap, CACHE_LEVEL_AND_TYPE__MAX);
for (node = caches; node; node = node->next) { for (node = caches; node; node = node->next) {
/* Prohibit users from repeating settings. */ /* Prohibit users from repeating settings. */
if (test_bit(node->value->cache, caches_bitmap)) { if (test_bit(node->value->cache, caches_bitmap)) {