SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

virtiofsd: prevent ".." escape in lo_do_lookup()

Browse Source 
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Sergio Lopez <slp@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
This commit is contained in:
Stefan Hajnoczi 2019-03-04 10:38:46 +00:00 committed by Dr. David Alan Gilbert
parent 7099575441
commit 854684bc0b
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/virtiofsd/passthrough_ll.c
View File

@ -624,12 +624,17 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent, const char *name,
int res; int res;
int saverr; int saverr;
struct lo_data *lo = lo_data(req); struct lo_data *lo = lo_data(req);
struct lo_inode *inode; struct lo_inode *inode, *dir = lo_inode(req, parent);
memset(e, 0, sizeof(*e)); memset(e, 0, sizeof(*e));
e->attr_timeout = lo->timeout; e->attr_timeout = lo->timeout;
e->entry_timeout = lo->timeout; e->entry_timeout = lo->timeout;
/* Do not allow escaping root directory */
if (dir == &lo->root && strcmp(name, "..") == 0) {
name = ".";
}
newfd = openat(lo_fd(req, parent), name, O_PATH | O_NOFOLLOW); newfd = openat(lo_fd(req, parent), name, O_PATH | O_NOFOLLOW);
if (newfd == -1) { if (newfd == -1) {
goto out_err; goto out_err;