hw/core/clock: allow clock_propagate on child clocks
clock_propagate() has an assert that clk->source is NULL, i.e. that you are calling it on a clock which has no source clock. This made sense in the original design where the only way for a clock's frequency to change if it had a source clock was when that source clock changed. However, we subsequently added multiplier/divider support, but didn't look at what that meant for propagation. If a clock-management device changes the multiplier or divider value on a clock, it needs to propagate that change down to child clocks, even if the clock has a source clock set. So the assertion is now incorrect. Remove the assertion. Signed-off-by: Raphael Poggi <raphael.poggi@lynxleap.co.uk> Message-id: 20240419162951.23558-1-raphael.poggi@lynxleap.co.uk Reviewed-by: Peter Maydell <peter.maydell@linaro.org> [PMM: Rewrote the commit message] Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
parent
5fee33d97a
commit
845dd0385e
@ -108,7 +108,6 @@ static void clock_propagate_period(Clock *clk, bool call_callbacks)
|
|||||||
|
|
||||||
void clock_propagate(Clock *clk)
|
void clock_propagate(Clock *clk)
|
||||||
{
|
{
|
||||||
assert(clk->source == NULL);
|
|
||||||
trace_clock_propagate(CLOCK_PATH(clk));
|
trace_clock_propagate(CLOCK_PATH(clk));
|
||||||
clock_propagate_period(clk, true);
|
clock_propagate_period(clk, true);
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user