SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

spapr: Fix failure path for attempting to hot unplug PCI bridges

Browse Source 
For various technical reasons we can't currently allow unplug a PCI to PCI
bridge on the pseries machine.  spapr_pci_unplug_request() correctly
generates an error message if that's attempted.

But.. if the given errp is not error_abort or error_fatal, it doesn't
actually stop trying to unplug the bridge anyway.

Fixes: 14e714900f6b "spapr: Allow hot plug/unplug of PCI bridges and devices under PCI bridges"
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Greg Kurz <groug@kaod.org>
This commit is contained in:
David Gibson 2020-03-26 16:12:40 +11:00
parent 4f7a11f93f
commit 7aab589976
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hw/ppc/spapr_pci.c
View File

@ -1663,6 +1663,7 @@ static void spapr_pci_unplug_request(HotplugHandler *plug_handler,
if (pc->is_bridge) { if (pc->is_bridge) {
error_setg(errp, "PCI: Hot unplug of PCI bridges not supported"); error_setg(errp, "PCI: Hot unplug of PCI bridges not supported");
return;
} }
/* ensure any other present functions are pending unplug */ /* ensure any other present functions are pending unplug */