SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

target/sparc: Fix gdbstub incorrectly handling registers f32-f62

Browse Source 
The gdbstub implementation for the Sparc architecture would
incorrectly calculate the the floating point register offset.
This resulted in, for example, registers f32 and f34 to point to
the same value.

The issue was caused by the confusion between even register numbers
and even register indexes. For example, the register index of f32 is 64
and f34 is 65.

Cc: qemu-stable@nongnu.org
Fixes: 30038fd81808 ("target-sparc: Change fpr representation to doubles.")
Signed-off-by: Mikael Szreder <git@miszr.win>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20250214070343.11501-1-git@miszr.win>
This commit is contained in:
Mikael Szreder 2025-02-14 08:03:43 +01:00 committed by Richard Henderson
parent 807c3ebd1e
commit 7a74e46808
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
target/sparc/gdbstub.c
View File

@ -79,8 +79,13 @@ int sparc_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n)
} }
} }
if (n < 80) { if (n < 80) {
/* f32-f62 (double width, even numbers only) */ /* f32-f62 (16 double width registers, even register numbers only)
return gdb_get_reg64(mem_buf, env->fpr[(n - 32) / 2].ll); * n == 64: f32 : env->fpr[16]
* n == 65: f34 : env->fpr[17]
* etc...
* n == 79: f62 : env->fpr[31]
*/
return gdb_get_reg64(mem_buf, env->fpr[(n - 64) + 16].ll);
} }
switch (n) { switch (n) {
case 80: case 80:
@ -173,8 +178,13 @@ int sparc_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)
} }
return 4; return 4;
} else if (n < 80) { } else if (n < 80) {
/* f32-f62 (double width, even numbers only) */ /* f32-f62 (16 double width registers, even register numbers only)
env->fpr[(n - 32) / 2].ll = tmp; * n == 64: f32 : env->fpr[16]
* n == 65: f34 : env->fpr[17]
* etc...
* n == 79: f62 : env->fpr[31]
*/
env->fpr[(n - 64) + 16].ll = tmp;
} else { } else {
switch (n) { switch (n) {
case 80: case 80: