SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

target/arm: Report correct syndrome for UNDEFINED LOR sysregs when NS=0

Browse Source 
The pseudocode for the accessors for the LOR sysregs says they
are UNDEFINED if SCR_EL3.NS is 0. We were reporting the wrong
syndrome value here; use CP_ACCESS_TRAP_UNCATEGORIZED.

Cc: qemu-stable@nongnu.org
Fixes: 2d7137c10faf ("target/arm: Implement the ARMv8.1-LOR extension")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20250130182309.717346-5-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2025-01-30 18:22:59 +00:00
parent ccda792945
commit 707d478ed8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
target/arm/helper.c
View File

@ -6750,8 +6750,8 @@ static CPAccessResult access_lor_other(CPUARMState *env,
const ARMCPRegInfo *ri, bool isread) const ARMCPRegInfo *ri, bool isread)
{ {
if (arm_is_secure_below_el3(env)) { if (arm_is_secure_below_el3(env)) {
/* Access denied in secure mode. */ /* UNDEF if SCR_EL3.NS == 0 */
return CP_ACCESS_TRAP; return CP_ACCESS_TRAP_UNCATEGORIZED;
} }
return access_lor_ns(env, ri, isread); return access_lor_ns(env, ri, isread);
} }