SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

qemu-options: Factor out get_opt_name_value() helper

Browse Source 
The next commits will put it to use.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20200415074927.19897-3-armbru@redhat.com>
This commit is contained in:
Markus Armbruster 2020-04-15 09:49:20 +02:00
parent 32c2dcf5e8
commit 6129803b55
1 changed files with 56 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

102
util/qemu-option.c
View File

@ -805,61 +805,71 @@ void qemu_opts_print(QemuOpts *opts, const char *separator)
} }
} }
static const char *get_opt_name_value(const char *params,
const char *firstname,
char **name, char **value)
{
const char *p, *pe, *pc;
pe = strchr(params, '=');
pc = strchr(params, ',');
if (!pe || (pc && pc < pe)) {
/* found "foo,more" */
if (firstname) {
/* implicitly named first option */
*name = g_strdup(firstname);
p = get_opt_value(params, value);
} else {
/* option without value, must be a flag */
p = get_opt_name(params, name, ',');
if (strncmp(*name, "no", 2) == 0) {
memmove(*name, *name + 2, strlen(*name + 2) + 1);
*value = g_strdup("off");
} else {
*value = g_strdup("on");
}
}
} else {
/* found "foo=bar,more" */
p = get_opt_name(params, name, '=');
assert(*p == '=');
p++;
p = get_opt_value(p, value);
}
assert(!*p || *p == ',');
if (*p == ',') {
p++;
}
return p;
}
static void opts_do_parse(QemuOpts *opts, const char *params, static void opts_do_parse(QemuOpts *opts, const char *params,
const char *firstname, bool prepend, const char *firstname, bool prepend,
bool *invalidp, Error **errp) bool *invalidp, Error **errp)
{ {
char *option = NULL;
char *value = NULL;
const char *p,*pe,*pc;
Error *local_err = NULL; Error *local_err = NULL;
char *option, *value;
const char *p;
for (p = params; *p != '\0'; p++) { for (p = params; *p;) {
pe = strchr(p, '='); p = get_opt_name_value(p, firstname, &option, &value);
pc = strchr(p, ','); firstname = NULL;
if (!pe || (pc && pc < pe)) {
/* found "foo,more" */ if (!strcmp(option, "id")) {
if (p == params && firstname) { g_free(option);
/* implicitly named first option */ g_free(value);
option = g_strdup(firstname); continue;
p = get_opt_value(p, &value);
} else {
/* option without value, probably a flag */
p = get_opt_name(p, &option, ',');
if (strncmp(option, "no", 2) == 0) {
memmove(option, option+2, strlen(option+2)+1);
value = g_strdup("off");
} else {
value = g_strdup("on");
}
}
} else {
/* found "foo=bar,more" */
p = get_opt_name(p, &option, '=');
assert(*p == '=');
p++;
p = get_opt_value(p, &value);
}
if (strcmp(option, "id") != 0) {
/* store and parse */
opt_set(opts, option, value, prepend, invalidp, &local_err);
value = NULL;
if (local_err) {
error_propagate(errp, local_err);
goto cleanup;
}
}
if (*p != ',') {
break;
} }
opt_set(opts, option, value, prepend, invalidp, &local_err);
g_free(option); g_free(option);
g_free(value); if (local_err) {
option = value = NULL; error_propagate(errp, local_err);
return;
}
} }
cleanup:
g_free(option);
g_free(value);
} }
/** /**