SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hw/loongarch/virt: Remove unused assignment

Browse Source 
There is abuse usage about local variable gap. Remove
duplicated assignment and solve Coverity reported error.

Resolves: Coverity CID 1546441
Fixes: 3cc451cbce ("hw/loongarch: Refine fwcfg memory map")
Signed-off-by: Bibo Mao <maobibo@loongson.cn>
Reviewed-by: Song Gao <gaosong@loongson.cn>
Message-Id: <20240612033637.167787-1-maobibo@loongson.cn>
Signed-off-by: Song Gao <gaosong@loongson.cn>
This commit is contained in:
Bibo Mao 2024-06-12 11:36:37 +08:00 committed by Song Gao
parent 0aca736433
commit 5efbc384c6
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
hw/loongarch/virt.c
View File

@ -1054,7 +1054,6 @@ static void fw_cfg_add_memory(MachineState *ms)
memmap_add_entry(base, gap, 1); memmap_add_entry(base, gap, 1);
size -= gap; size -= gap;
base = VIRT_HIGHMEM_BASE; base = VIRT_HIGHMEM_BASE;
gap = ram_size - VIRT_LOWMEM_SIZE;
} }
if (size) { if (size) {
@ -1067,17 +1066,17 @@ static void fw_cfg_add_memory(MachineState *ms)
} }
/* add fw_cfg memory map of other nodes */ /* add fw_cfg memory map of other nodes */
size = ram_size - numa_info[0].node_mem; if (numa_info[0].node_mem < gap && ram_size > gap) {
gap = VIRT_LOWMEM_BASE + VIRT_LOWMEM_SIZE;
if (base < gap && (base + size) > gap) {
/* /*
* memory map for the maining nodes splited into two part * memory map for the maining nodes splited into two part
* lowram: [base, +(gap - base)) * lowram: [base, +(gap - numa_info[0].node_mem))
* highram: [VIRT_HIGHMEM_BASE, +(size - (gap - base))) * highram: [VIRT_HIGHMEM_BASE, +(ram_size - gap))
*/ */
memmap_add_entry(base, gap - base, 1); memmap_add_entry(base, gap - numa_info[0].node_mem, 1);
size -= gap - base; size = ram_size - gap;
base = VIRT_HIGHMEM_BASE; base = VIRT_HIGHMEM_BASE;
} else {
size = ram_size - numa_info[0].node_mem;
} }
if (size) if (size)