SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

target/hppa: Speed up hppa_is_pa20()

Browse Source 
Although the hppa_is_pa20() helper is costly due to string comparisons
in object_dynamic_cast(), it is called quite often during memory lookups
and at each start of a block of instruction translations.
Speed hppa_is_pa20() up by calling object_dynamic_cast() only once at
CPU creation and store the result in the is_pa20 of struct CPUArchState.

Signed-off-by: Helge Deller <deller@gmx.de>
Co-developed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20241231190620.24442-7-philmd@linaro.org>
This commit is contained in:
Helge Deller 2024-12-30 00:41:54 +01:00 committed by Philippe Mathieu-Daudé
parent 46f7be06c8
commit 5c27cbd7b2
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
target/hppa/cpu.c
View File

@ -193,6 +193,13 @@ static void hppa_cpu_realizefn(DeviceState *dev, Error **errp)
tcg_cflags_set(cs, CF_PCREL); tcg_cflags_set(cs, CF_PCREL);
} }
static void hppa_cpu_initfn(Object *obj)
{
CPUHPPAState *env = cpu_env(CPU(obj));
env->is_pa20 = !!object_dynamic_cast(obj, TYPE_HPPA64_CPU);
}
static void hppa_cpu_reset_hold(Object *obj, ResetType type) static void hppa_cpu_reset_hold(Object *obj, ResetType type)
{ {
HPPACPUClass *scc = HPPA_CPU_GET_CLASS(obj); HPPACPUClass *scc = HPPA_CPU_GET_CLASS(obj);
@ -282,6 +289,7 @@ static const TypeInfo hppa_cpu_type_infos[] = {
.parent = TYPE_CPU, .parent = TYPE_CPU,
.instance_size = sizeof(HPPACPU), .instance_size = sizeof(HPPACPU),
.instance_align = __alignof(HPPACPU), .instance_align = __alignof(HPPACPU),
.instance_init = hppa_cpu_initfn,
.abstract = false, .abstract = false,
.class_size = sizeof(HPPACPUClass), .class_size = sizeof(HPPACPUClass),
.class_init = hppa_cpu_class_init, .class_init = hppa_cpu_class_init,

6
target/hppa/cpu.h
View File

@ -266,6 +266,8 @@ typedef struct CPUArchState {
/* Fields up to this point are cleared by a CPU reset */ /* Fields up to this point are cleared by a CPU reset */
struct {} end_reset_fields; struct {} end_reset_fields;
bool is_pa20;
} CPUHPPAState; } CPUHPPAState;
/** /**
@ -297,9 +299,9 @@ struct HPPACPUClass {
#include "exec/cpu-all.h" #include "exec/cpu-all.h"
static inline bool hppa_is_pa20(CPUHPPAState *env) static inline bool hppa_is_pa20(const CPUHPPAState *env)
{ {
return object_dynamic_cast(OBJECT(env_cpu(env)), TYPE_HPPA64_CPU) != NULL; return env->is_pa20;
} }
static inline int HPPA_BTLB_ENTRIES(CPUHPPAState *env) static inline int HPPA_BTLB_ENTRIES(CPUHPPAState *env)