SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ppc/pnv: I2C controller is not user creatable

Browse Source 
The I2C controller is a subunit of the processor. Make it so and avoid
QEMU crashes.

  $ build/qemu-system-ppc64 -S -machine powernv9 -device pnv-i2c
  qemu-system-ppc64: ../hw/ppc/pnv_i2c.c:521: pnv_i2c_realize: Assertion `i2c->chip' failed.
  Aborted (core dumped)

Fixes: 263b81ee15af ("ppc/pnv: Add an I2C controller model")
Cc: Glenn Miles <milesg@linux.vnet.ibm.com>
Reported-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Glenn Miles <milesg@linux.vnet.ibm.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
This commit is contained in:
Cédric Le Goater 2024-03-18 16:58:44 +01:00
parent 5700114462
commit 5b2b9450a2
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hw/ppc/pnv_i2c.c
View File

@ -557,6 +557,9 @@ static void pnv_i2c_class_init(ObjectClass *klass, void *data)
xscomc->dt_xscom = pnv_i2c_dt_xscom; xscomc->dt_xscom = pnv_i2c_dt_xscom;
/* Reason: This device is part of the CPU and cannot be used separately */
dc->user_creatable = false;
dc->desc = "PowerNV I2C"; dc->desc = "PowerNV I2C";
dc->realize = pnv_i2c_realize; dc->realize = pnv_i2c_realize;
device_class_set_props(dc, pnv_i2c_properties); device_class_set_props(dc, pnv_i2c_properties);