SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

linux-user/hppa: lock both words of function descriptor

Browse Source 
The code in setup_rt_frame reads two words at haddr, but locks only one.
This patch fixes it to lock both.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Acked-by: Helge Deller <deller@gmx.de>
Cc: qemu-stable@nongnu.org
Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
Mikulas Patocka 2023-09-16 18:32:45 +02:00 committed by Helge Deller
parent 2529497cb6
commit 5b1270ef14
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
linux-user/hppa/signal.c
View File

@ -149,12 +149,13 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
target_ulong *fdesc, dest; target_ulong *fdesc, dest;
haddr &= -4; haddr &= -4;
if (!lock_user_struct(VERIFY_READ, fdesc, haddr, 1)) { fdesc = lock_user(VERIFY_READ, haddr, 2 * sizeof(target_ulong), 1);
if (!fdesc) {
goto give_sigsegv; goto give_sigsegv;
} }
__get_user(dest, fdesc); __get_user(dest, fdesc);
__get_user(env->gr[19], fdesc + 1); __get_user(env->gr[19], fdesc + 1);
unlock_user_struct(fdesc, haddr, 1); unlock_user(fdesc, haddr, 0);
haddr = dest; haddr = dest;
} }
env->iaoq_f = haddr; env->iaoq_f = haddr;