SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

usb-storage: tag usb_msd_csw as packed struct

Browse Source 
Without this the struct has the wrong size: sizeof() evaluates
to 16 instead of 13.  In most cases the bug is hidden by the
fact that guests submits a buffer which is exactly 13 bytes
long, so the padding added by the compiler is simply ignored.

But sometimes guests submit a larger buffer and expect a short
transfer, which does not work properly with the wrong struct
size.

Cc: vintagepc404@protonmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Fixes: a917d384ac0 ("SCSI TCQ support.")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210906045523.1259629-1-kraxel@redhat.com>
This commit is contained in:
Gerd Hoffmann 2021-09-06 06:55:23 +02:00
parent 7c8d295b27
commit 58d7d4c786
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/hw/usb/msd.h
View File

@ -17,7 +17,7 @@ enum USBMSDMode {
USB_MSDM_CSW /* Command Status. */ USB_MSDM_CSW /* Command Status. */
}; };
struct usb_msd_csw { struct QEMU_PACKED usb_msd_csw {
uint32_t sig; uint32_t sig;
uint32_t tag; uint32_t tag;
uint32_t residue; uint32_t residue;