SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

sev: use explicit indices for mapping firmware error codes to strings

Browse Source 
This can help lower any margin for error when making future additions to
the list, especially if they're made out of order.

While doing so, make capitalization of ASID consistent with its usage in
the SEV firmware spec (Asid -> ASID).

Signed-off-by: Connor Kuehl <ckuehl@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210430134830.254741-2-ckuehl@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
Connor Kuehl 2021-04-30 08:48:29 -05:00 committed by Eduardo Habkost
parent 3ea1a80243
commit 5811b936bf
1 changed files with 23 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
target/i386/sev.c
View File

@ -87,29 +87,29 @@ static SevGuestState *sev_guest;
static Error *sev_mig_blocker; static Error *sev_mig_blocker;
static const char *const sev_fw_errlist[] = { static const char *const sev_fw_errlist[] = {
"", [SEV_RET_SUCCESS] = "",
"Platform state is invalid", [SEV_RET_INVALID_PLATFORM_STATE] = "Platform state is invalid",
"Guest state is invalid", [SEV_RET_INVALID_GUEST_STATE] = "Guest state is invalid",
"Platform configuration is invalid", [SEV_RET_INAVLID_CONFIG] = "Platform configuration is invalid",
"Buffer too small", [SEV_RET_INVALID_LEN] = "Buffer too small",
"Platform is already owned", [SEV_RET_ALREADY_OWNED] = "Platform is already owned",
"Certificate is invalid", [SEV_RET_INVALID_CERTIFICATE] = "Certificate is invalid",
"Policy is not allowed", [SEV_RET_POLICY_FAILURE] = "Policy is not allowed",
"Guest is not active", [SEV_RET_INACTIVE] = "Guest is not active",
"Invalid address", [SEV_RET_INVALID_ADDRESS] = "Invalid address",
"Bad signature", [SEV_RET_BAD_SIGNATURE] = "Bad signature",
"Bad measurement", [SEV_RET_BAD_MEASUREMENT] = "Bad measurement",
"Asid is already owned", [SEV_RET_ASID_OWNED] = "ASID is already owned",
"Invalid ASID", [SEV_RET_INVALID_ASID] = "Invalid ASID",
"WBINVD is required", [SEV_RET_WBINVD_REQUIRED] = "WBINVD is required",
"DF_FLUSH is required", [SEV_RET_DFFLUSH_REQUIRED] = "DF_FLUSH is required",
"Guest handle is invalid", [SEV_RET_INVALID_GUEST] = "Guest handle is invalid",
"Invalid command", [SEV_RET_INVALID_COMMAND] = "Invalid command",
"Guest is active", [SEV_RET_ACTIVE] = "Guest is active",
"Hardware error", [SEV_RET_HWSEV_RET_PLATFORM] = "Hardware error",
"Hardware unsafe", [SEV_RET_HWSEV_RET_UNSAFE] = "Hardware unsafe",
"Feature not supported", [SEV_RET_UNSUPPORTED] = "Feature not supported",
"Invalid parameter" [SEV_RET_INVALID_PARAM] = "Invalid parameter",
}; };
#define SEV_FW_MAX_ERROR ARRAY_SIZE(sev_fw_errlist) #define SEV_FW_MAX_ERROR ARRAY_SIZE(sev_fw_errlist)