SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gdbstub: specialise stub_can_reverse

Browse Source 
Currently we only support replay for softmmu mode so it is a constant
false for user-mode.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-18-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-18-richard.henderson@linaro.org>
This commit is contained in:
Alex Bennée 2023-03-02 18:57:53 -08:00
parent 7ea0c33def
commit 505601d580
4 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gdbstub/gdbstub.c
View File

@ -113,15 +113,6 @@ int use_gdb_syscalls(void)
return gdb_syscall_mode == GDB_SYS_ENABLED; return gdb_syscall_mode == GDB_SYS_ENABLED;
} }
static bool stub_can_reverse(void)
{
#ifdef CONFIG_USER_ONLY
return false;
#else
return replay_mode == REPLAY_MODE_PLAY;
#endif
}
/* writes 2*len+1 bytes in buf */ /* writes 2*len+1 bytes in buf */
void gdb_memtohex(GString *buf, const uint8_t *mem, int len) void gdb_memtohex(GString *buf, const uint8_t *mem, int len)
{ {
@ -1308,7 +1299,7 @@ static void handle_step(GArray *params, void *user_ctx)
static void handle_backward(GArray *params, void *user_ctx) static void handle_backward(GArray *params, void *user_ctx)
{ {
if (!stub_can_reverse()) { if (!gdb_can_reverse()) {
gdb_put_packet("E22"); gdb_put_packet("E22");
} }
if (params->len == 1) { if (params->len == 1) {
@ -1559,7 +1550,7 @@ static void handle_query_supported(GArray *params, void *user_ctx)
g_string_append(gdbserver_state.str_buf, ";qXfer:features:read+"); g_string_append(gdbserver_state.str_buf, ";qXfer:features:read+");
} }
if (stub_can_reverse()) { if (gdb_can_reverse()) {
g_string_append(gdbserver_state.str_buf, g_string_append(gdbserver_state.str_buf,
";ReverseStep+;ReverseContinue+"); ";ReverseStep+;ReverseContinue+");
} }

1
gdbstub/internals.h
View File

@ -130,6 +130,7 @@ CPUState *gdb_first_attached_cpu(void);
void gdb_append_thread_id(CPUState *cpu, GString *buf); void gdb_append_thread_id(CPUState *cpu, GString *buf);
int gdb_get_cpu_index(CPUState *cpu); int gdb_get_cpu_index(CPUState *cpu);
unsigned int gdb_get_max_cpus(void); /* both */ unsigned int gdb_get_max_cpus(void); /* both */
bool gdb_can_reverse(void); /* softmmu, stub for user */
void gdb_create_default_process(GDBState *s); void gdb_create_default_process(GDBState *s);

5
gdbstub/softmmu.c
View File

@ -450,6 +450,11 @@ unsigned int gdb_get_max_cpus(void)
return ms->smp.max_cpus; return ms->smp.max_cpus;
} }
bool gdb_can_reverse(void)
{
return replay_mode == REPLAY_MODE_PLAY;
}
/* /*
* Softmmu specific command helpers * Softmmu specific command helpers
*/ */

5
gdbstub/user.c
View File

@ -409,6 +409,11 @@ unsigned int gdb_get_max_cpus(void)
return max_cpus; return max_cpus;
} }
/* replay not supported for user-mode */
bool gdb_can_reverse(void)
{
return false;
}
/* /*
* Break/Watch point helpers * Break/Watch point helpers