SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment

Browse Source 
Fix warning reported by Clang static code analyzer:

    CC      tools/virtiofsd/passthrough_ll.o
  tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to 'newfd' is never read
          newfd = -1;
          ^       ~~
  tools/virtiofsd/passthrough_ll.c:942:9: warning: Value stored to 'newfd' is never read
          newfd = -1;
          ^       ~~

Fixes: 7c6b66027
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
This commit is contained in:
Philippe Mathieu-Daudé 2020-02-17 10:42:39 +01:00 committed by Dr. David Alan Gilbert
parent d4db6f545d
commit 4e1fb9e7bc
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/virtiofsd/passthrough_ll.c
View File

@ -922,7 +922,6 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent, const char *name,
inode = lo_find(lo, &e->attr); inode = lo_find(lo, &e->attr);
if (inode) { if (inode) {
close(newfd); close(newfd);
newfd = -1;
} else { } else {
inode = calloc(1, sizeof(struct lo_inode)); inode = calloc(1, sizeof(struct lo_inode));
if (!inode) { if (!inode) {
@ -939,7 +938,6 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent, const char *name,
inode->nlookup = 1; inode->nlookup = 1;
inode->fd = newfd; inode->fd = newfd;
newfd = -1;
inode->key.ino = e->attr.st_ino; inode->key.ino = e->attr.st_ino;
inode->key.dev = e->attr.st_dev; inode->key.dev = e->attr.st_dev;
pthread_mutex_init(&inode->plock_mutex, NULL); pthread_mutex_init(&inode->plock_mutex, NULL);