SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

util/interval-tree: Use qatomic_set_mb in rb_link_node

Browse Source 
Ensure that the stores to rb_left and rb_right are complete before
inserting the new node into the tree.  Otherwise a concurrent reader
could see garbage in the new leaf.

Cc: qemu-stable@nongnu.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2023-07-22 15:25:30 +01:00
parent 055b86e0f0
commit 4c8baa02d3
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
util/interval-tree.c
View File

@ -128,7 +128,11 @@ static inline void rb_link_node(RBNode *node, RBNode *parent, RBNode **rb_link)
node->rb_parent_color = (uintptr_t)parent; node->rb_parent_color = (uintptr_t)parent;
node->rb_left = node->rb_right = NULL; node->rb_left = node->rb_right = NULL;
qatomic_set(rb_link, node); /*
* Ensure that node is initialized before insertion,
* as viewed by a concurrent search.
*/
qatomic_set_mb(rb_link, node);
} }
static RBNode *rb_next(RBNode *node) static RBNode *rb_next(RBNode *node)