SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

target/hexagon: fix = vs. == mishap

Browse Source 
**** Changes in v2 ****
Fix yyassert's for sign and zero extends

Coverity reports a parameter that is "set but never used".  This is caused
by an assignment operator being used instead of equality.

Co-authored-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Tested-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230428204411.1400931-1-tsimpson@quicinc.com>
This commit is contained in:
Paolo Bonzini 2023-04-27 14:56:32 +02:00 committed by Taylor Simpson
parent 163e5fa38e
commit 4354f3dbae
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
target/hexagon/idef-parser/idef-parser.y
View File

@ -683,7 +683,7 @@ rvalue : FAIL
yyassert(c, &@1, $5.type == IMMEDIATE && yyassert(c, &@1, $5.type == IMMEDIATE &&
$5.imm.type == VALUE, $5.imm.type == VALUE,
"SXT expects immediate values\n"); "SXT expects immediate values\n");
$$ = gen_extend_op(c, &@1, &$3, $5.imm.value, &$7, SIGNED); $$ = gen_extend_op(c, &@1, &$3, 64, &$7, SIGNED);
} }
| ZXT '(' rvalue ',' IMM ',' rvalue ')' | ZXT '(' rvalue ',' IMM ',' rvalue ')'
{ {
@ -691,7 +691,7 @@ rvalue : FAIL
yyassert(c, &@1, $5.type == IMMEDIATE && yyassert(c, &@1, $5.type == IMMEDIATE &&
$5.imm.type == VALUE, $5.imm.type == VALUE,
"ZXT expects immediate values\n"); "ZXT expects immediate values\n");
$$ = gen_extend_op(c, &@1, &$3, $5.imm.value, &$7, UNSIGNED); $$ = gen_extend_op(c, &@1, &$3, 64, &$7, UNSIGNED);
} }
| '(' rvalue ')' | '(' rvalue ')'
{ {

2
target/hexagon/idef-parser/parser-helpers.c
View File

@ -1120,7 +1120,7 @@ HexValue gen_extend_op(Context *c,
HexValue *value, HexValue *value,
HexSignedness signedness) HexSignedness signedness)
{ {
unsigned bit_width = (dst_width = 64) ? 64 : 32; unsigned bit_width = (dst_width == 64) ? 64 : 32;
HexValue value_m = *value; HexValue value_m = *value;
HexValue src_width_m = *src_width; HexValue src_width_m = *src_width;