SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

migration: process_incoming_migration_co(): fix reporting s->error

Browse Source 
It's bad idea to leave critical section with error object freed, but
s->error still set, this theoretically may lead to use-after-free
crash. Let's avoid it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
This commit is contained in:
Vladimir Sementsov-Ogievskiy 2024-04-30 11:56:44 +03:00 committed by Fabiano Rosas
parent 246f54e0cc
commit 30116e9079
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
migration/migration.c
View File

@ -784,6 +784,7 @@ process_incoming_migration_co(void *opaque)
if (migrate_has_error(s)) { if (migrate_has_error(s)) {
WITH_QEMU_LOCK_GUARD(&s->error_mutex) { WITH_QEMU_LOCK_GUARD(&s->error_mutex) {
error_report_err(s->error); error_report_err(s->error);
s->error = NULL;
} }
} }
error_report("load of migration failed: %s", strerror(-ret)); error_report("load of migration failed: %s", strerror(-ret));