SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

target/arm: Reformat comments in add_cpreg_to_hashtable

Browse Source 
Put the block comments into the current coding style.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220501055028.646596-19-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Richard Henderson 2022-04-30 22:50:00 -07:00 committed by Peter Maydell
parent dc44545b0d
commit 1859f8c35a
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
target/arm/helper.c
View File

@ -8496,15 +8496,16 @@ CpuDefinitionInfoList *qmp_query_cpu_definitions(Error **errp)
return cpu_list; return cpu_list;
} }
/*
* Private utility function for define_one_arm_cp_reg_with_opaque():
* add a single reginfo struct to the hash table.
*/
static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r, static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r,
void *opaque, CPState state, void *opaque, CPState state,
CPSecureState secstate, CPSecureState secstate,
int crm, int opc1, int opc2, int crm, int opc1, int opc2,
const char *name) const char *name)
{ {
/* Private utility function for define_one_arm_cp_reg_with_opaque():
* add a single reginfo struct to the hash table.
*/
uint32_t key; uint32_t key;
ARMCPRegInfo *r2; ARMCPRegInfo *r2;
bool is64 = r->type & ARM_CP_64BIT; bool is64 = r->type & ARM_CP_64BIT;
@ -8568,7 +8569,8 @@ static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r,
isbanked = r->bank_fieldoffsets[0] && r->bank_fieldoffsets[1]; isbanked = r->bank_fieldoffsets[0] && r->bank_fieldoffsets[1];
if (isbanked) { if (isbanked) {
/* Register is banked (using both entries in array). /*
* Register is banked (using both entries in array).
* Overwriting fieldoffset as the array is only used to define * Overwriting fieldoffset as the array is only used to define
* banked registers but later only fieldoffset is used. * banked registers but later only fieldoffset is used.
*/ */
@ -8577,7 +8579,8 @@ static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r,
if (state == ARM_CP_STATE_AA32) { if (state == ARM_CP_STATE_AA32) {
if (isbanked) { if (isbanked) {
/* If the register is banked then we don't need to migrate or /*
* If the register is banked then we don't need to migrate or
* reset the 32-bit instance in certain cases: * reset the 32-bit instance in certain cases:
* *
* 1) If the register has both 32-bit and 64-bit instances then we * 1) If the register has both 32-bit and 64-bit instances then we
@ -8592,8 +8595,9 @@ static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r,
r2->type |= ARM_CP_ALIAS; r2->type |= ARM_CP_ALIAS;
} }
} else if ((secstate != r->secure) && !ns) { } else if ((secstate != r->secure) && !ns) {
/* The register is not banked so we only want to allow migration of /*
* the non-secure instance. * The register is not banked so we only want to allow migration
* of the non-secure instance.
*/ */
r2->type |= ARM_CP_ALIAS; r2->type |= ARM_CP_ALIAS;
} }
@ -8607,7 +8611,8 @@ static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r,
} }
} }
/* By convention, for wildcarded registers only the first /*
* By convention, for wildcarded registers only the first
* entry is used for migration; the others are marked as * entry is used for migration; the others are marked as
* ALIAS so we don't try to transfer the register * ALIAS so we don't try to transfer the register
* multiple times. Special registers (ie NOP/WFI) are * multiple times. Special registers (ie NOP/WFI) are
@ -8622,7 +8627,8 @@ static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r,
r2->type |= ARM_CP_ALIAS | ARM_CP_NO_GDB; r2->type |= ARM_CP_ALIAS | ARM_CP_NO_GDB;
} }
/* Check that raw accesses are either forbidden or handled. Note that /*
* Check that raw accesses are either forbidden or handled. Note that
* we can't assert this earlier because the setup of fieldoffset for * we can't assert this earlier because the setup of fieldoffset for
* banked registers has to be done first. * banked registers has to be done first.
*/ */