SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tests/qtest/migration: Initialize buffer in probe_o_direct_support

Browse Source 
Valgrind complains about the probe_o_direct_support() function reading
from an uninitialized buffer. For probing O_DIRECT support we don't
actually need to write to the file, just make sure the pwrite call
doesn't reject the write. Still, write zeroes to the buffer to
suppress the warning.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <20241209204427.17763-3-farosas@suse.de>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
This commit is contained in:
Fabiano Rosas 2024-12-09 17:44:23 -03:00
parent cd196679f4
commit 117221ad99
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/qtest/migration/migration-util.c
View File

@ -284,6 +284,7 @@ bool probe_o_direct_support(const char *tmpfs)
buf = qemu_try_memalign(len, len); buf = qemu_try_memalign(len, len);
g_assert(buf); g_assert(buf);
memset(buf, 0, len);
ret = pwrite(fd, buf, len, offset); ret = pwrite(fd, buf, len, offset);
unlink(filename); unlink(filename);