SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

target/i386: Suppress coverity warning on fsave/frstor

Browse Source 
Coverity warns that 14 << data32 may overflow with respect
to the target_ulong to which it is subsequently added.
We know this wasn't true because data32 is in [1,2],
but the suggested fix is perfectly fine.

Fixes: Coverity CID 1487135, 1487256
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
Message-Id: <20220401184635.327423-1-richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2022-04-01 12:46:35 -06:00
parent 21641ee5a9
commit 0cbc135917
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
target/i386/tcg/fpu_helper.c
View File

@ -2466,7 +2466,7 @@ static void do_fsave(CPUX86State *env, target_ulong ptr, int data32,
do_fstenv(env, ptr, data32, retaddr); do_fstenv(env, ptr, data32, retaddr);
ptr += (14 << data32); ptr += (target_ulong)14 << data32;
for (i = 0; i < 8; i++) { for (i = 0; i < 8; i++) {
tmp = ST(i); tmp = ST(i);
do_fstt(env, tmp, ptr, retaddr); do_fstt(env, tmp, ptr, retaddr);
@ -2488,7 +2488,7 @@ static void do_frstor(CPUX86State *env, target_ulong ptr, int data32,
int i; int i;
do_fldenv(env, ptr, data32, retaddr); do_fldenv(env, ptr, data32, retaddr);
ptr += (14 << data32); ptr += (target_ulong)14 << data32;
for (i = 0; i < 8; i++) { for (i = 0; i < 8; i++) {
tmp = do_fldt(env, ptr, retaddr); tmp = do_fldt(env, ptr, retaddr);