SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

virtio-rng: block max-bytes=0

Browse Source 
with max-bytes set to 0, quota is 0 and so device does not work.
block this to avoid user confusion

Message-Id: <73a89a42d82ec8b47358f25119b87063e4a6ea57.1721818306.git.mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This commit is contained in:
Michael S. Tsirkin 2024-07-24 06:48:59 -04:00
parent e9d2db818f
commit 024d046bf4
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hw/virtio/virtio-rng.c
View File

@ -184,8 +184,9 @@ static void virtio_rng_device_realize(DeviceState *dev, Error **errp)
/* Workaround: Property parsing does not enforce unsigned integers, /* Workaround: Property parsing does not enforce unsigned integers,
* So this is a hack to reject such numbers. */ * So this is a hack to reject such numbers. */
if (vrng->conf.max_bytes > INT64_MAX) { if (vrng->conf.max_bytes == 0 ||
error_setg(errp, "'max-bytes' parameter must be non-negative, " vrng->conf.max_bytes > INT64_MAX) {
error_setg(errp, "'max-bytes' parameter must be positive, "
"and less than 2^63"); "and less than 2^63");
return; return;
} }