minor doc changes

This commit is contained in:
Pedro 2015-01-06 20:01:10 +01:00
parent 71f9252019
commit 0c309ad658
2 changed files with 6 additions and 5 deletions

View File

@ -28,11 +28,13 @@ typedef struct Expr Expr;
/** /**
* @class Expr * @class Expr
* @brief Represents SQL expressions (i.e. literals, operators, column_refs) * @brief Represents SQL expressions (i.e. literals, operators, column_refs)
*
* TODO: When destructing a placeholder expression, we might need to alter the placeholder_list
*/ */
struct Expr { struct Expr {
/** /**
* Operator types. These are important for expressions of type kExprOperator * Operator types. These are important for expressions of type kExprOperator
* Trivial types are those that can be descriped by a sigle character e.g: * Trivial types are those that can be described by a single character e.g:
* + - * / < > = % * + - * / < > = %
* Non-trivial are: * Non-trivial are:
* <> <= >= LIKE ISNULL NOT * <> <= >= LIKE ISNULL NOT
@ -64,8 +66,8 @@ struct Expr {
alias(NULL) {}; alias(NULL) {};
// Interesting side-effect: // Interesting side-effect:
// Making the destructor virtual causes segmentation faults // Making the destructor virtual used to cause segmentation faults
~Expr(); Expr();
ExprType type; ExprType type;

View File

@ -498,7 +498,6 @@ opt_where:
| /* empty */ { $$ = NULL; } | /* empty */ { $$ = NULL; }
; ;
// TODO: having
opt_group: opt_group:
GROUP BY expr_list opt_having { GROUP BY expr_list opt_having {
$$ = new GroupByDescription(); $$ = new GroupByDescription();
@ -626,7 +625,7 @@ star_expr:
'*' { $$ = new Expr(kExprStar); } '*' { $$ = new Expr(kExprStar); }
; ;
/* TODO: keep list of placeholders */
placeholder_expr: placeholder_expr:
'?' { '?' {
$$ = Expr::makePlaceholder(yylloc.total_column); $$ = Expr::makePlaceholder(yylloc.total_column);