From ff589d9a89f47f63624609ea1fbc8aae2c67f5ee Mon Sep 17 00:00:00 2001
From: Dominik Maier <domenukk@gmail.com>
Date: Tue, 3 Aug 2021 12:51:20 +0200
Subject: [PATCH] clippy fixes

---
 libafl/src/bolts/os/unix_signals.rs | 1 -
 libafl/src/fuzzer/mod.rs            | 4 ++--
 libafl/src/stages/power.rs          | 1 +
 libafl_qemu/src/amd64.rs            | 1 -
 libafl_qemu/src/x86.rs              | 1 -
 libafl_sugar/src/inmemory.rs        | 6 ++++--
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/libafl/src/bolts/os/unix_signals.rs b/libafl/src/bolts/os/unix_signals.rs
index 509f9c3e6e..002d2aed6d 100644
--- a/libafl/src/bolts/os/unix_signals.rs
+++ b/libafl/src/bolts/os/unix_signals.rs
@@ -26,7 +26,6 @@ pub use libc::{c_void, siginfo_t};
 /// All signals on this system, as `enum`.
 #[derive(IntoPrimitive, TryFromPrimitive, Clone, Copy)]
 #[repr(i32)]
-#[allow(clippy::pub_enum_variant_names)]
 pub enum Signal {
     /// `SIGABRT` signal id
     SigAbort = SIGABRT,
diff --git a/libafl/src/fuzzer/mod.rs b/libafl/src/fuzzer/mod.rs
index 6a798b656a..dc5e472f95 100644
--- a/libafl/src/fuzzer/mod.rs
+++ b/libafl/src/fuzzer/mod.rs
@@ -337,7 +337,7 @@ where
         #[cfg(feature = "introspection")]
         let is_solution = self
             .objective_mut()
-            .is_interesting_introspection(state, manager, &input, observers, &exit_kind)?;
+            .is_interesting_introspection(state, manager, &input, observers, exit_kind)?;
 
         if is_solution {
             res = ExecuteInputResult::Solution;
@@ -350,7 +350,7 @@ where
             #[cfg(feature = "introspection")]
             let is_corpus = self
                 .feedback_mut()
-                .is_interesting_introspection(state, manager, &input, observers, &exit_kind)?;
+                .is_interesting_introspection(state, manager, &input, observers, exit_kind)?;
 
             if is_corpus {
                 res = ExecuteInputResult::Corpus;
diff --git a/libafl/src/stages/power.rs b/libafl/src/stages/power.rs
index cfe26ff011..4f984c8715 100644
--- a/libafl/src/stages/power.rs
+++ b/libafl/src/stages/power.rs
@@ -204,6 +204,7 @@ where
 
     /// Compute the parameter `μ` used in the COE schedule.
     #[inline]
+    #[allow(clippy::unused_self)]
     pub fn fuzz_mu(&self, state: &S, psmeta: &PowerScheduleMetadata) -> Result<f64, Error> {
         let corpus = state.corpus();
         let mut n_paths = 0;
diff --git a/libafl_qemu/src/amd64.rs b/libafl_qemu/src/amd64.rs
index 28f64ef2ce..537f371c69 100644
--- a/libafl_qemu/src/amd64.rs
+++ b/libafl_qemu/src/amd64.rs
@@ -2,7 +2,6 @@ use num_enum::{IntoPrimitive, TryFromPrimitive};
 
 #[derive(IntoPrimitive, TryFromPrimitive, Clone, Copy)]
 #[repr(i32)]
-#[allow(clippy::pub_enum_variant_names)]
 pub enum Amd64Regs {
     Rax = 0,
     Rbx = 1,
diff --git a/libafl_qemu/src/x86.rs b/libafl_qemu/src/x86.rs
index d93ab25931..e3371c1a40 100644
--- a/libafl_qemu/src/x86.rs
+++ b/libafl_qemu/src/x86.rs
@@ -2,7 +2,6 @@ use num_enum::{IntoPrimitive, TryFromPrimitive};
 
 #[derive(IntoPrimitive, TryFromPrimitive, Clone, Copy)]
 #[repr(i32)]
-#[allow(clippy::pub_enum_variant_names)]
 pub enum X86Regs {
     Eax = 0,
     Ebx = 1,
diff --git a/libafl_sugar/src/inmemory.rs b/libafl_sugar/src/inmemory.rs
index babed9b5c9..a8f55cc3c2 100644
--- a/libafl_sugar/src/inmemory.rs
+++ b/libafl_sugar/src/inmemory.rs
@@ -66,10 +66,12 @@ where
     harness: Option<H>,
 }
 
+#[allow(clippy::similar_names)]
 impl<'a, H> InMemoryBytesCoverageSugar<'a, H>
 where
     H: FnMut(&[u8]),
 {
+    #[allow(clippy::too_many_lines)]
     pub fn run(&mut self) {
         let conf = self
             .configuration
@@ -192,7 +194,7 @@ where
                     println!("Loading from {:?}", &self.input_dirs);
                     // Load from disk
                     state
-                        .load_initial_inputs(&mut fuzzer, &mut executor, &mut mgr, &self.input_dirs)
+                        .load_initial_inputs(&mut fuzzer, &mut executor, &mut mgr, self.input_dirs)
                         .unwrap_or_else(|_| {
                             panic!("Failed to load initial corpus at {:?}", &self.input_dirs);
                         });
@@ -228,7 +230,7 @@ where
             .configuration(conf)
             .stats(stats)
             .run_client(&mut run_client)
-            .cores(&self.cores)
+            .cores(self.cores)
             .broker_port(self.broker_port)
             .remote_broker_addr(self.remote_broker_addr);
         #[cfg(unix)]