From d4a86cdeeb819fcaca40214b9f1f9c55b614be0b Mon Sep 17 00:00:00 2001 From: "Dongjia \"toka\" Zhang" Date: Fri, 14 Mar 2025 14:30:54 +0100 Subject: [PATCH] Hide Forkserver constructor API (#3076) --- libafl/src/executors/forkserver.rs | 35 ++---------------------------- 1 file changed, 2 insertions(+), 33 deletions(-) diff --git a/libafl/src/executors/forkserver.rs b/libafl/src/executors/forkserver.rs index 5fa4e3c237..9d00b8e2d0 100644 --- a/libafl/src/executors/forkserver.rs +++ b/libafl/src/executors/forkserver.rs @@ -315,42 +315,11 @@ const fn fs_opt_get_mapsize(x: i32) -> i32 { #[expect(clippy::fn_params_excessive_bools)] impl Forkserver { - /// Create a new [`Forkserver`] - #[expect(clippy::too_many_arguments)] - pub fn new( - target: OsString, - args: Vec, - envs: Vec<(OsString, OsString)>, - input_filefd: RawFd, - use_stdin: bool, - memlimit: u64, - is_persistent: bool, - is_deferred_frksrv: bool, - dump_asan_logs: bool, - coverage_map_size: Option, - debug_output: bool, - ) -> Result { - Self::with_kill_signal( - target, - args, - envs, - input_filefd, - use_stdin, - memlimit, - is_persistent, - is_deferred_frksrv, - dump_asan_logs, - coverage_map_size, - debug_output, - KILL_SIGNAL_DEFAULT, - ) - } - /// Create a new [`Forkserver`] that will kill child processes /// with the given `kill_signal`. /// Using `Forkserver::new(..)` will default to [`Signal::SIGTERM`]. #[expect(clippy::too_many_arguments)] - pub fn with_kill_signal( + fn new( target: OsString, args: Vec, envs: Vec<(OsString, OsString)>, @@ -992,7 +961,7 @@ where }; let mut forkserver = match &self.program { - Some(t) => Forkserver::with_kill_signal( + Some(t) => Forkserver::new( t.clone(), self.arguments.clone(), self.envs.clone(),