diff --git a/fuzzers/baby_fuzzer_grimoire/src/main.rs b/fuzzers/baby_fuzzer_grimoire/src/main.rs index 8945a36f52..f80a58b620 100644 --- a/fuzzers/baby_fuzzer_grimoire/src/main.rs +++ b/fuzzers/baby_fuzzer_grimoire/src/main.rs @@ -85,7 +85,7 @@ pub fn main() { let observer = unsafe { StdMapObserver::new("signals", &mut SIGNALS) }; // Feedback to rate the interestingness of an input - let mut feedback = MaxMapFeedback::new_tracking(&observer, false, true); + let mut feedback = MaxMapFeedback::tracking(&observer, false, true); // A feedback to choose if an input is a solution or not let mut objective = CrashFeedback::new(); diff --git a/fuzzers/baby_fuzzer_minimizing/src/main.rs b/fuzzers/baby_fuzzer_minimizing/src/main.rs index a87010ab2d..e9e2a4850c 100644 --- a/fuzzers/baby_fuzzer_minimizing/src/main.rs +++ b/fuzzers/baby_fuzzer_minimizing/src/main.rs @@ -35,7 +35,7 @@ pub fn main() -> Result<(), Error> { let observer = unsafe { StdMapObserver::from_mut_ptr("signals", SIGNALS.as_mut_ptr(), SIGNALS.len()) }; - let factory = MapEqualityFactory::new_from_observer(&observer); + let factory = MapEqualityFactory::with_observer(&observer); // Feedback to rate the interestingness of an input let mut feedback = MaxMapFeedback::new(&observer); diff --git a/fuzzers/backtrace_baby_fuzzers/forkserver_executor/src/main.rs b/fuzzers/backtrace_baby_fuzzers/forkserver_executor/src/main.rs index cdf9847e9e..8d8c87a5e8 100644 --- a/fuzzers/backtrace_baby_fuzzers/forkserver_executor/src/main.rs +++ b/fuzzers/backtrace_baby_fuzzers/forkserver_executor/src/main.rs @@ -54,7 +54,7 @@ pub fn main() { // Feedback to rate the interestingness of an input // This one is composed by two Feedbacks in OR - let mut feedback = MaxMapFeedback::new_tracking(&edges_observer, true, false); + let mut feedback = MaxMapFeedback::tracking(&edges_observer, true, false); // A feedback to choose if an input is a solution or not // We want to do the same crash deduplication that AFL does diff --git a/fuzzers/forkserver_libafl_cc/src/main.rs b/fuzzers/forkserver_libafl_cc/src/main.rs index 6f34fe587d..b84472326a 100644 --- a/fuzzers/forkserver_libafl_cc/src/main.rs +++ b/fuzzers/forkserver_libafl_cc/src/main.rs @@ -113,7 +113,7 @@ pub fn main() { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/forkserver_simple/src/main.rs b/fuzzers/forkserver_simple/src/main.rs index ca4f2932d6..8ff0dc16da 100644 --- a/fuzzers/forkserver_simple/src/main.rs +++ b/fuzzers/forkserver_simple/src/main.rs @@ -113,7 +113,7 @@ pub fn main() { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/frida_gdiplus/src/fuzzer.rs b/fuzzers/frida_gdiplus/src/fuzzer.rs index 233f6ff114..d8ab41cdb0 100644 --- a/fuzzers/frida_gdiplus/src/fuzzer.rs +++ b/fuzzers/frida_gdiplus/src/fuzzer.rs @@ -121,7 +121,7 @@ unsafe fn fuzz(options: &FuzzerOptions) -> Result<(), Error> { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); @@ -237,7 +237,7 @@ unsafe fn fuzz(options: &FuzzerOptions) -> Result<(), Error> { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); @@ -367,7 +367,7 @@ unsafe fn fuzz(options: &FuzzerOptions) -> Result<(), Error> { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/frida_libpng/src/fuzzer.rs b/fuzzers/frida_libpng/src/fuzzer.rs index fc53cf4684..b46b516b09 100644 --- a/fuzzers/frida_libpng/src/fuzzer.rs +++ b/fuzzers/frida_libpng/src/fuzzer.rs @@ -118,7 +118,7 @@ unsafe fn fuzz(options: &FuzzerOptions) -> Result<(), Error> { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); @@ -235,7 +235,7 @@ unsafe fn fuzz(options: &FuzzerOptions) -> Result<(), Error> { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); @@ -365,7 +365,7 @@ unsafe fn fuzz(options: &FuzzerOptions) -> Result<(), Error> { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/fuzzbench/src/lib.rs b/fuzzers/fuzzbench/src/lib.rs index d3f1265eac..e8239ac60e 100644 --- a/fuzzers/fuzzbench/src/lib.rs +++ b/fuzzers/fuzzbench/src/lib.rs @@ -249,7 +249,7 @@ fn fuzz( let cmplog_observer = CmpLogObserver::new("cmplog", true); - let map_feedback = MaxMapFeedback::new_tracking(&edges_observer, true, false); + let map_feedback = MaxMapFeedback::tracking(&edges_observer, true, false); let calibration = CalibrationStage::new(&map_feedback); diff --git a/fuzzers/fuzzbench_fork_qemu/src/fuzzer.rs b/fuzzers/fuzzbench_fork_qemu/src/fuzzer.rs index 5e248ca7cc..9999fa272f 100644 --- a/fuzzers/fuzzbench_fork_qemu/src/fuzzer.rs +++ b/fuzzers/fuzzbench_fork_qemu/src/fuzzer.rs @@ -246,7 +246,7 @@ fn fuzz( // Create an observation channel using cmplog map let cmplog_observer = unsafe { CmpLogObserver::with_map_ptr("cmplog", cmplog_map_ptr, true) }; - let map_feedback = MaxMapFeedback::new_tracking(&edges_observer, true, false); + let map_feedback = MaxMapFeedback::tracking(&edges_observer, true, false); let calibration = CalibrationStage::new(&map_feedback); diff --git a/fuzzers/fuzzbench_forkserver/src/main.rs b/fuzzers/fuzzbench_forkserver/src/main.rs index db5dd23e9e..313f0f8827 100644 --- a/fuzzers/fuzzbench_forkserver/src/main.rs +++ b/fuzzers/fuzzbench_forkserver/src/main.rs @@ -251,7 +251,7 @@ fn fuzz( // Create an observation channel to keep track of the execution time let time_observer = TimeObserver::new("time"); - let map_feedback = MaxMapFeedback::new_tracking(&edges_observer, true, false); + let map_feedback = MaxMapFeedback::tracking(&edges_observer, true, false); let calibration = CalibrationStage::new(&map_feedback); diff --git a/fuzzers/fuzzbench_qemu/src/fuzzer.rs b/fuzzers/fuzzbench_qemu/src/fuzzer.rs index 618b2c0910..9486834254 100644 --- a/fuzzers/fuzzbench_qemu/src/fuzzer.rs +++ b/fuzzers/fuzzbench_qemu/src/fuzzer.rs @@ -258,7 +258,7 @@ fn fuzz( // Create an observation channel using cmplog map let cmplog_observer = CmpLogObserver::new("cmplog", true); - let map_feedback = MaxMapFeedback::new_tracking(&edges_observer, true, false); + let map_feedback = MaxMapFeedback::tracking(&edges_observer, true, false); let calibration = CalibrationStage::new(&map_feedback); diff --git a/fuzzers/fuzzbench_text/src/lib.rs b/fuzzers/fuzzbench_text/src/lib.rs index 37ddfaa5f3..948df0a63d 100644 --- a/fuzzers/fuzzbench_text/src/lib.rs +++ b/fuzzers/fuzzbench_text/src/lib.rs @@ -311,7 +311,7 @@ fn fuzz_binary( let cmplog_observer = CmpLogObserver::new("cmplog", true); - let map_feedback = MaxMapFeedback::new_tracking(&edges_observer, true, false); + let map_feedback = MaxMapFeedback::tracking(&edges_observer, true, false); let calibration = CalibrationStage::new(&map_feedback); @@ -515,7 +515,7 @@ fn fuzz_text( let cmplog_observer = CmpLogObserver::new("cmplog", true); // New maximization map feedback linked to the edges observer and the feedback state - let map_feedback = MaxMapFeedback::new_tracking(&edges_observer, true, true); + let map_feedback = MaxMapFeedback::tracking(&edges_observer, true, true); let calibration = CalibrationStage::new(&map_feedback); diff --git a/fuzzers/libafl_atheris/src/lib.rs b/fuzzers/libafl_atheris/src/lib.rs index 8e7a814e79..8d99f52ac3 100644 --- a/fuzzers/libafl_atheris/src/lib.rs +++ b/fuzzers/libafl_atheris/src/lib.rs @@ -208,7 +208,7 @@ pub fn LLVMFuzzerRunDriver( // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/libfuzzer_libpng/src/lib.rs b/fuzzers/libfuzzer_libpng/src/lib.rs index 19e880e80e..35b5fe5db5 100644 --- a/fuzzers/libfuzzer_libpng/src/lib.rs +++ b/fuzzers/libfuzzer_libpng/src/lib.rs @@ -90,7 +90,7 @@ fn fuzz(corpus_dirs: &[PathBuf], objective_dir: PathBuf, broker_port: u16) -> Re // Create an observation channel to keep track of the execution time let time_observer = TimeObserver::new("time"); - let map_feedback = MaxMapFeedback::new_tracking(&edges_observer, true, false); + let map_feedback = MaxMapFeedback::tracking(&edges_observer, true, false); let calibration = CalibrationStage::new(&map_feedback); diff --git a/fuzzers/libfuzzer_libpng_accounting/src/lib.rs b/fuzzers/libfuzzer_libpng_accounting/src/lib.rs index 15c0987512..ce62e5ed7d 100644 --- a/fuzzers/libfuzzer_libpng_accounting/src/lib.rs +++ b/fuzzers/libfuzzer_libpng_accounting/src/lib.rs @@ -144,7 +144,7 @@ pub fn libafl_main() { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/libfuzzer_libpng_cmin/src/lib.rs b/fuzzers/libfuzzer_libpng_cmin/src/lib.rs index c459e111c9..1fc59e6bf2 100644 --- a/fuzzers/libfuzzer_libpng_cmin/src/lib.rs +++ b/fuzzers/libfuzzer_libpng_cmin/src/lib.rs @@ -89,7 +89,7 @@ fn fuzz(corpus_dirs: &[PathBuf], objective_dir: PathBuf, broker_port: u16) -> Re // Create an observation channel to keep track of the execution time let time_observer = TimeObserver::new("time"); - let map_feedback = MaxMapFeedback::new_tracking(&edges_observer, true, false); + let map_feedback = MaxMapFeedback::tracking(&edges_observer, true, false); let calibration = CalibrationStage::new(&map_feedback); diff --git a/fuzzers/libfuzzer_libpng_ctx/src/lib.rs b/fuzzers/libfuzzer_libpng_ctx/src/lib.rs index 25d2460e87..9ae48549c8 100644 --- a/fuzzers/libfuzzer_libpng_ctx/src/lib.rs +++ b/fuzzers/libfuzzer_libpng_ctx/src/lib.rs @@ -138,7 +138,7 @@ pub fn libafl_main() { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/libfuzzer_libpng_launcher/src/lib.rs b/fuzzers/libfuzzer_libpng_launcher/src/lib.rs index f24dff75ec..d7667f2a7d 100644 --- a/fuzzers/libfuzzer_libpng_launcher/src/lib.rs +++ b/fuzzers/libfuzzer_libpng_launcher/src/lib.rs @@ -143,7 +143,7 @@ pub fn libafl_main() { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/libfuzzer_stb_image/src/main.rs b/fuzzers/libfuzzer_stb_image/src/main.rs index 768adfaca0..e80360a11b 100644 --- a/fuzzers/libfuzzer_stb_image/src/main.rs +++ b/fuzzers/libfuzzer_stb_image/src/main.rs @@ -79,7 +79,7 @@ fn fuzz(corpus_dirs: &[PathBuf], objective_dir: PathBuf, broker_port: u16) -> Re // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/libfuzzer_stb_image_concolic/fuzzer/src/main.rs b/fuzzers/libfuzzer_stb_image_concolic/fuzzer/src/main.rs index 5ce433c7b1..45de3ded48 100644 --- a/fuzzers/libfuzzer_stb_image_concolic/fuzzer/src/main.rs +++ b/fuzzers/libfuzzer_stb_image_concolic/fuzzer/src/main.rs @@ -116,7 +116,7 @@ fn fuzz( // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/libfuzzer_windows_asan/src/lib.rs b/fuzzers/libfuzzer_windows_asan/src/lib.rs index 66db4f2352..0cb39415a7 100644 --- a/fuzzers/libfuzzer_windows_asan/src/lib.rs +++ b/fuzzers/libfuzzer_windows_asan/src/lib.rs @@ -66,7 +66,7 @@ fn fuzz(corpus_dirs: &[PathBuf], objective_dir: PathBuf, broker_port: u16) -> Re // Create an observation channel to keep track of the execution time let time_observer = TimeObserver::new("time"); - let map_feedback = MaxMapFeedback::new_tracking(&edges_observer, true, false); + let map_feedback = MaxMapFeedback::tracking(&edges_observer, true, false); let calibration = CalibrationStage::new(&map_feedback); diff --git a/fuzzers/nautilus_sync/src/lib.rs b/fuzzers/nautilus_sync/src/lib.rs index 9b2340629e..7f87766931 100644 --- a/fuzzers/nautilus_sync/src/lib.rs +++ b/fuzzers/nautilus_sync/src/lib.rs @@ -122,7 +122,7 @@ pub fn libafl_main() { let context = NautilusContext::from_file(15, "grammar.json"); let mut event_converter = opt.bytes_broker_port.map(|port| { - LlmpEventConverter::new_on_port( + LlmpEventConverter::on_port( shmem_provider.clone(), port, Some(NautilusToBytesInputConverter::new(&context)), diff --git a/fuzzers/qemu_arm_launcher/src/fuzzer.rs b/fuzzers/qemu_arm_launcher/src/fuzzer.rs index f9e8d3e386..215ca354aa 100644 --- a/fuzzers/qemu_arm_launcher/src/fuzzer.rs +++ b/fuzzers/qemu_arm_launcher/src/fuzzer.rs @@ -123,7 +123,7 @@ pub fn fuzz() { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/qemu_launcher/src/fuzzer.rs b/fuzzers/qemu_launcher/src/fuzzer.rs index f5422c4e9d..7bd59fb616 100644 --- a/fuzzers/qemu_launcher/src/fuzzer.rs +++ b/fuzzers/qemu_launcher/src/fuzzer.rs @@ -127,7 +127,7 @@ pub fn fuzz() { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/qemu_systemmode/src/fuzzer.rs b/fuzzers/qemu_systemmode/src/fuzzer.rs index 13d17d0122..814c817d47 100644 --- a/fuzzers/qemu_systemmode/src/fuzzer.rs +++ b/fuzzers/qemu_systemmode/src/fuzzer.rs @@ -155,7 +155,7 @@ pub fn fuzz() { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, true), + MaxMapFeedback::tracking(&edges_observer, true, true), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/fuzzers/tutorial/src/lib.rs b/fuzzers/tutorial/src/lib.rs index 8688ea9e8a..725b732890 100644 --- a/fuzzers/tutorial/src/lib.rs +++ b/fuzzers/tutorial/src/lib.rs @@ -86,7 +86,7 @@ fn fuzz(corpus_dirs: &[PathBuf], objective_dir: PathBuf, broker_port: u16) -> Re // Create an observation channel to keep track of the execution time let time_observer = TimeObserver::new("time"); - let map_feedback = MaxMapFeedback::new_tracking(&edges_observer, true, false); + let map_feedback = MaxMapFeedback::tracking(&edges_observer, true, false); let calibration = CalibrationStage::new(&map_feedback); diff --git a/libafl/src/events/llmp.rs b/libafl/src/events/llmp.rs index 164ffc88a9..8936b49c83 100644 --- a/libafl/src/events/llmp.rs +++ b/libafl/src/events/llmp.rs @@ -103,7 +103,7 @@ where /// Create llmp on a port /// The port must not be bound yet to have a broker. #[cfg(feature = "std")] - pub fn new_on_port(shmem_provider: SP, monitor: MT, port: u16) -> Result { + pub fn on_port(shmem_provider: SP, monitor: MT, port: u16) -> Result { Ok(Self { monitor, llmp: llmp::LlmpBroker::create_attach_to_tcp(shmem_provider, port)?, @@ -371,7 +371,7 @@ where /// If the port is not yet bound, it will act as broker /// Else, it will act as client. #[cfg(feature = "std")] - pub fn new_on_port( + pub fn on_port( shmem_provider: SP, port: u16, configuration: EventConfig, @@ -937,7 +937,7 @@ where } } ManagerKind::Broker => { - let event_broker = LlmpEventBroker::::new_on_port( + let event_broker = LlmpEventBroker::::on_port( self.shmem_provider.clone(), self.monitor.take().unwrap(), self.broker_port, @@ -948,7 +948,7 @@ where } ManagerKind::Client { cpu_core } => { // We are a client - let mgr = LlmpEventManager::::new_on_port( + let mgr = LlmpEventManager::::on_port( self.shmem_provider.clone(), self.broker_port, self.configuration, @@ -1166,7 +1166,7 @@ where /// Create a client from port and the input converters #[cfg(feature = "std")] - pub fn new_on_port( + pub fn on_port( shmem_provider: SP, port: u16, converter: Option, diff --git a/libafl/src/events/simple.rs b/libafl/src/events/simple.rs index 610af3cb81..f11136316b 100644 --- a/libafl/src/events/simple.rs +++ b/libafl/src/events/simple.rs @@ -429,7 +429,7 @@ where MT: Monitor, //TODO CE: CustomEvent, { /// Creates a new [`SimpleEventManager`]. - fn new_launched(monitor: MT, staterestorer: StateRestorer) -> Self { + fn launched(monitor: MT, staterestorer: StateRestorer) -> Self { Self { staterestorer, simple_event_mgr: SimpleEventManager::new(monitor), @@ -535,7 +535,7 @@ where // Mgr to send and receive msgs from/to all other fuzzer instances ( None, - SimpleRestartingEventManager::new_launched(monitor, staterestorer), + SimpleRestartingEventManager::launched(monitor, staterestorer), ) } // Restoring from a previous run, deserialize state and corpus. @@ -551,7 +551,7 @@ where ( Some(state), - SimpleRestartingEventManager::new_launched(monitor, staterestorer), + SimpleRestartingEventManager::launched(monitor, staterestorer), ) } }; diff --git a/libafl/src/feedbacks/map.rs b/libafl/src/feedbacks/map.rs index 93af4b783f..e838f16f2f 100644 --- a/libafl/src/feedbacks/map.rs +++ b/libafl/src/feedbacks/map.rs @@ -666,7 +666,7 @@ where /// Create new `MapFeedback` specifying if it must track indexes of used entries and/or novelties #[must_use] - pub fn new_tracking(map_observer: &O, track_indexes: bool, track_novelties: bool) -> Self { + pub fn tracking(map_observer: &O, track_indexes: bool, track_novelties: bool) -> Self { Self { indexes: track_indexes, novelties: if track_novelties { Some(vec![]) } else { None }, diff --git a/libafl/src/observers/map.rs b/libafl/src/observers/map.rs index 9801c2bb97..cdba713774 100644 --- a/libafl/src/observers/map.rs +++ b/libafl/src/observers/map.rs @@ -558,7 +558,7 @@ where /// Creates a new [`MapObserver`] with an owned map #[must_use] - pub fn new_owned(name: S, map: Vec) -> Self + pub fn owned(name: S, map: Vec) -> Self where S: Into, { @@ -905,7 +905,7 @@ where /// Creates a new [`MapObserver`] with an owned map #[must_use] - pub fn new_owned(name: &'static str, map: Vec) -> Self { + pub fn owned(name: &'static str, map: Vec) -> Self { assert!(map.len() >= N); let initial = if map.is_empty() { T::default() } else { map[0] }; Self { @@ -1828,7 +1828,7 @@ where { /// Creates a new [`MultiMapObserver`], maybe in differential mode #[must_use] - fn new_maybe_differential(name: &'static str, maps: Vec>) -> Self { + fn maybe_differential(name: &'static str, maps: Vec>) -> Self { let mut idx = 0; let mut builder = vec![]; for (v, x) in maps.iter().enumerate() { @@ -1855,7 +1855,7 @@ where /// Creates a new [`MultiMapObserver`] in differential mode #[must_use] pub fn differential(name: &'static str, maps: Vec>) -> Self { - Self::new_maybe_differential(name, maps) + Self::maybe_differential(name, maps) } } @@ -1866,12 +1866,12 @@ where /// Creates a new [`MultiMapObserver`] #[must_use] pub fn new(name: &'static str, maps: Vec>) -> Self { - Self::new_maybe_differential(name, maps) + Self::maybe_differential(name, maps) } /// Creates a new [`MultiMapObserver`] with an owned map #[must_use] - pub fn new_owned(name: &'static str, maps: Vec>) -> Self { + pub fn owned(name: &'static str, maps: Vec>) -> Self { let mut idx = 0; let mut v = 0; let mut builder = vec![]; diff --git a/libafl/src/stages/logics.rs b/libafl/src/stages/logics.rs index 6f50712ce1..8663dadd09 100644 --- a/libafl/src/stages/logics.rs +++ b/libafl/src/stages/logics.rs @@ -77,6 +77,8 @@ where } } +/// A conditionally enabled stage. +/// If the closure returns true, the wrapped stage will be executed, else it will be skipped. #[derive(Debug)] pub struct IfStage where @@ -134,7 +136,8 @@ where ST: StagesTuple, Z: UsesState, { - /// Constructor + /// Constructor for this conditionally enabled stage. + /// If the closure returns true, the wrapped stage will be executed, else it will be skipped. pub fn new(closure: CB, if_stages: ST) -> Self { Self { closure, diff --git a/libafl_frida/src/asan/errors.rs b/libafl_frida/src/asan/errors.rs index 981bb69291..4be258c9de 100644 --- a/libafl_frida/src/asan/errors.rs +++ b/libafl_frida/src/asan/errors.rs @@ -578,7 +578,7 @@ impl AsanErrorsObserver { /// Creates a new `AsanErrorsObserver`, owning the `AsanErrors` #[must_use] - pub fn new_owned(errors: Option) -> Self { + pub fn owned(errors: Option) -> Self { Self { errors: OwnedPtr::Owned(Box::new(errors)), } diff --git a/libafl_sugar/src/forkserver.rs b/libafl_sugar/src/forkserver.rs index 9fc4a599cb..2c8da33400 100644 --- a/libafl_sugar/src/forkserver.rs +++ b/libafl_sugar/src/forkserver.rs @@ -136,7 +136,7 @@ impl<'a, const MAP_SIZE: usize> ForkserverBytesCoverageSugar<'a, MAP_SIZE> { // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/libafl_sugar/src/inmemory.rs b/libafl_sugar/src/inmemory.rs index 8bd04d096c..a406a69dd1 100644 --- a/libafl_sugar/src/inmemory.rs +++ b/libafl_sugar/src/inmemory.rs @@ -155,7 +155,7 @@ where // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/libafl_sugar/src/qemu.rs b/libafl_sugar/src/qemu.rs index 109dd8d232..192b318b43 100644 --- a/libafl_sugar/src/qemu.rs +++ b/libafl_sugar/src/qemu.rs @@ -166,7 +166,7 @@ where // This one is composed by two Feedbacks in OR let mut feedback = feedback_or!( // New maximization map feedback linked to the edges observer and the feedback state - MaxMapFeedback::new_tracking(&edges_observer, true, false), + MaxMapFeedback::tracking(&edges_observer, true, false), // Time feedback, this one does not need a feedback state TimeFeedback::with_observer(&time_observer) ); diff --git a/libafl_targets/src/drcov.rs b/libafl_targets/src/drcov.rs index fa47d20c7b..7998f661a9 100644 --- a/libafl_targets/src/drcov.rs +++ b/libafl_targets/src/drcov.rs @@ -45,7 +45,7 @@ impl DrCovBasicBlock { /// Create a new [`DrCovBasicBlock`] with a given `start` address and a block size. #[must_use] - pub fn new_with_size(start: usize, size: usize) -> Self { + pub fn with_size(start: usize, size: usize) -> Self { Self::new(start, start + size) } }