From ac783c61190502f5f0356147f7cf191d616fe382 Mon Sep 17 00:00:00 2001
From: Andrea Fioraldi <andreafioraldi@gmail.com>
Date: Thu, 15 Jul 2021 09:58:23 +0200
Subject: [PATCH] Fix inifnite serialization for CmpValuesMetadata

---
 libafl/src/observers/cmp.rs | 16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

diff --git a/libafl/src/observers/cmp.rs b/libafl/src/observers/cmp.rs
index 11486fe132..48d7ae33a8 100644
--- a/libafl/src/observers/cmp.rs
+++ b/libafl/src/observers/cmp.rs
@@ -5,7 +5,7 @@ use alloc::{
     vec::Vec,
 };
 
-use serde::{de::DeserializeOwned, Deserialize, Serialize, Serializer};
+use serde::{de::DeserializeOwned, Deserialize, Serialize};
 
 use crate::{
     bolts::{ownedref::OwnedRefMut, tuples::Named, AsSlice},
@@ -45,25 +45,15 @@ impl CmpValues {
 }
 
 /// A state metadata holding a list of values logged from comparisons
-#[derive(Default, Deserialize)]
+#[derive(Default, Serialize, Deserialize)]
 pub struct CmpValuesMetadata {
     /// A `list` of values.
+    #[serde(skip)]
     pub list: Vec<CmpValues>,
 }
 
 crate::impl_serdeany!(CmpValuesMetadata);
 
-impl Serialize for CmpValuesMetadata {
-    /// Serialzie to an empty object, we don't need to keep it in State after reset
-    fn serialize<S>(&self, se: S) -> Result<S::Ok, S::Error>
-    where
-        S: Serializer,
-    {
-        let empty = CmpValuesMetadata::new();
-        empty.serialize(se)
-    }
-}
-
 impl AsSlice<CmpValues> for CmpValuesMetadata {
     /// Convert to a slice
     #[must_use]