From 8f6efe993db0f316cd546d0ba9354da59fb0ae58 Mon Sep 17 00:00:00 2001 From: Addison Crump Date: Tue, 19 Sep 2023 00:42:46 +0200 Subject: [PATCH] Address recent clippy changes; build clippy in debug instead of release for perf (#1516) --- libafl/src/lib.rs | 1 - libafl_bolts/src/lib.rs | 1 - libafl_cc/src/lib.rs | 1 - libafl_concolic/symcc_runtime/src/lib.rs | 2 +- libafl_derive/src/lib.rs | 1 - libafl_frida/src/lib.rs | 1 - libafl_libfuzzer/libafl_libfuzzer_runtime/src/lib.rs | 1 - libafl_sugar/src/lib.rs | 1 - libafl_targets/src/lib.rs | 1 - libafl_tinyinst/src/lib.rs | 1 - scripts/clippy.sh | 4 ++-- 11 files changed, 3 insertions(+), 12 deletions(-) diff --git a/libafl/src/lib.rs b/libafl/src/lib.rs index afada3902d..c3660ad9bb 100644 --- a/libafl/src/lib.rs +++ b/libafl/src/lib.rs @@ -61,7 +61,6 @@ Welcome to `LibAFL` overflowing_literals, path_statements, patterns_in_fns_without_body, - private_in_public, unconditional_recursion, unused, unused_allocation, diff --git a/libafl_bolts/src/lib.rs b/libafl_bolts/src/lib.rs index 7511f1c424..906d29e37f 100644 --- a/libafl_bolts/src/lib.rs +++ b/libafl_bolts/src/lib.rs @@ -62,7 +62,6 @@ overflowing_literals, path_statements, patterns_in_fns_without_body, - private_in_public, unconditional_recursion, unused, unused_allocation, diff --git a/libafl_cc/src/lib.rs b/libafl_cc/src/lib.rs index 1793b8ff42..a442ab0bcc 100644 --- a/libafl_cc/src/lib.rs +++ b/libafl_cc/src/lib.rs @@ -48,7 +48,6 @@ overflowing_literals, path_statements, patterns_in_fns_without_body, - private_in_public, unconditional_recursion, unused, unused_allocation, diff --git a/libafl_concolic/symcc_runtime/src/lib.rs b/libafl_concolic/symcc_runtime/src/lib.rs index 15c6c4fb0e..4097dca95c 100644 --- a/libafl_concolic/symcc_runtime/src/lib.rs +++ b/libafl_concolic/symcc_runtime/src/lib.rs @@ -127,7 +127,7 @@ macro_rules! unwrap_option { }; } -/// Creates an exported extern C function for the given runtime function declaration, forwarding to the runtime as obtained by $rt_cb (which should be `fn (fn (&mut impl Runtime))`). +/// Creates an exported extern C function for the given runtime function declaration, forwarding to the runtime as obtained by `$rt_cb` (which should be `fn (fn (&mut impl Runtime))`). #[doc(hidden)] #[macro_export] macro_rules! export_rust_runtime_fn { diff --git a/libafl_derive/src/lib.rs b/libafl_derive/src/lib.rs index a6797d6d71..fa91639283 100644 --- a/libafl_derive/src/lib.rs +++ b/libafl_derive/src/lib.rs @@ -49,7 +49,6 @@ overflowing_literals, path_statements, patterns_in_fns_without_body, - private_in_public, unconditional_recursion, unused, unused_allocation, diff --git a/libafl_frida/src/lib.rs b/libafl_frida/src/lib.rs index c9819fc39f..01efee2ccf 100644 --- a/libafl_frida/src/lib.rs +++ b/libafl_frida/src/lib.rs @@ -55,7 +55,6 @@ Additional documentation is available in [the `LibAFL` book](https://aflplus.plu overflowing_literals, path_statements, patterns_in_fns_without_body, - private_in_public, unconditional_recursion, unused, unused_allocation, diff --git a/libafl_libfuzzer/libafl_libfuzzer_runtime/src/lib.rs b/libafl_libfuzzer/libafl_libfuzzer_runtime/src/lib.rs index f150d82aa7..6e5850d17f 100644 --- a/libafl_libfuzzer/libafl_libfuzzer_runtime/src/lib.rs +++ b/libafl_libfuzzer/libafl_libfuzzer_runtime/src/lib.rs @@ -58,7 +58,6 @@ overflowing_literals, path_statements, patterns_in_fns_without_body, - private_in_public, unconditional_recursion, unused, unused_allocation, diff --git a/libafl_sugar/src/lib.rs b/libafl_sugar/src/lib.rs index 561a675823..fb41e4a5aa 100644 --- a/libafl_sugar/src/lib.rs +++ b/libafl_sugar/src/lib.rs @@ -48,7 +48,6 @@ overflowing_literals, path_statements, patterns_in_fns_without_body, - private_in_public, unconditional_recursion, unused, unused_allocation, diff --git a/libafl_targets/src/lib.rs b/libafl_targets/src/lib.rs index f90507256c..7e6467b03d 100644 --- a/libafl_targets/src/lib.rs +++ b/libafl_targets/src/lib.rs @@ -50,7 +50,6 @@ overflowing_literals, path_statements, patterns_in_fns_without_body, - private_in_public, unconditional_recursion, unused, unused_allocation, diff --git a/libafl_tinyinst/src/lib.rs b/libafl_tinyinst/src/lib.rs index 47d70339c1..ffd4c26edd 100644 --- a/libafl_tinyinst/src/lib.rs +++ b/libafl_tinyinst/src/lib.rs @@ -52,7 +52,6 @@ The tinyinst module for `LibAFL`. overflowing_literals, path_statements, patterns_in_fns_without_body, - private_in_public, unconditional_recursion, unused, unused_allocation, diff --git a/scripts/clippy.sh b/scripts/clippy.sh index 5645909e06..6f7395ef57 100755 --- a/scripts/clippy.sh +++ b/scripts/clippy.sh @@ -4,7 +4,7 @@ cd "$SCRIPT_DIR/.." || exit 1 set -e -RUST_BACKTRACE=full cargo +nightly clippy --all --all-features --release --tests --examples --benches -- -Z macro-backtrace \ +RUST_BACKTRACE=full cargo +nightly clippy --all --all-features --tests --examples --benches -- -Z macro-backtrace \ -D clippy::all \ -D clippy::pedantic \ -W clippy::similar_names \ @@ -21,7 +21,7 @@ RUST_BACKTRACE=full cargo +nightly clippy --all --all-features --release --tests if [[ "$OSTYPE" == "linux-gnu"* ]]; then cd libafl_libfuzzer/libafl_libfuzzer_runtime - RUST_BACKTRACE=full cargo +nightly clippy --all --all-features --release --tests --examples --benches -- -Z macro-backtrace \ + RUST_BACKTRACE=full cargo +nightly clippy --all --all-features --tests --examples --benches -- -Z macro-backtrace \ -D clippy::all \ -D clippy::pedantic \ -W clippy::similar_names \