diff --git a/libafl/src/events/mod.rs b/libafl/src/events/mod.rs index 154889e2ec..2018504b12 100644 --- a/libafl/src/events/mod.rs +++ b/libafl/src/events/mod.rs @@ -214,14 +214,12 @@ impl EventConfig { } impl From<&str> for EventConfig { - #[must_use] fn from(name: &str) -> Self { Self::from_name(name) } } impl From for EventConfig { - #[must_use] fn from(name: String) -> Self { Self::from_name(&name) } diff --git a/libafl/src/feedbacks/list.rs b/libafl/src/feedbacks/list.rs index 0a24ef1ead..6ca99d35da 100644 --- a/libafl/src/feedbacks/list.rs +++ b/libafl/src/feedbacks/list.rs @@ -43,7 +43,6 @@ impl ListFeedbackMetadata { } impl Default for ListFeedbackMetadata { - #[must_use] fn default() -> Self { Self::new() } diff --git a/libafl/src/feedbacks/map.rs b/libafl/src/feedbacks/map.rs index 59d219cb7a..0509e7dc7c 100644 --- a/libafl/src/feedbacks/map.rs +++ b/libafl/src/feedbacks/map.rs @@ -271,7 +271,6 @@ libafl_bolts::impl_serdeany!(MapNoveltiesMetadata); impl Deref for MapNoveltiesMetadata { type Target = [usize]; /// Convert to a slice - #[must_use] fn deref(&self) -> &[usize] { &self.list } @@ -279,7 +278,6 @@ impl Deref for MapNoveltiesMetadata { impl DerefMut for MapNoveltiesMetadata { /// Convert to a slice - #[must_use] fn deref_mut(&mut self) -> &mut [usize] { &mut self.list } diff --git a/libafl/src/feedbacks/new_hash_feedback.rs b/libafl/src/feedbacks/new_hash_feedback.rs index a48237c690..cb2039979c 100644 --- a/libafl/src/feedbacks/new_hash_feedback.rs +++ b/libafl/src/feedbacks/new_hash_feedback.rs @@ -76,7 +76,6 @@ impl NewHashFeedbackMetadata { impl HashSetState for NewHashFeedbackMetadata { /// Create new [`NewHashFeedbackMetadata`] using a name and a hash set. - #[must_use] fn with_hash_set(hash_set: HashSet) -> Self { Self { hash_set } } diff --git a/libafl/src/fuzzer/mod.rs b/libafl/src/fuzzer/mod.rs index a3d4790d23..2c5d700273 100644 --- a/libafl/src/fuzzer/mod.rs +++ b/libafl/src/fuzzer/mod.rs @@ -554,7 +554,6 @@ trait InputFilter { pub struct NopInputFilter; impl InputFilter for NopInputFilter { #[inline] - #[must_use] fn should_execute(&mut self, _input: &I) -> bool { true } @@ -579,7 +578,6 @@ impl BloomInputFilter { #[cfg(feature = "std")] impl InputFilter for BloomInputFilter { #[inline] - #[must_use] fn should_execute(&mut self, input: &I) -> bool { !self.bloom.insert(input) } diff --git a/libafl/src/inputs/encoded.rs b/libafl/src/inputs/encoded.rs index b602cd0e94..48a42a549e 100644 --- a/libafl/src/inputs/encoded.rs +++ b/libafl/src/inputs/encoded.rs @@ -201,7 +201,6 @@ pub struct EncodedInput { impl Input for EncodedInput { /// Generate a name for this input - #[must_use] fn generate_name(&self, _id: Option) -> String { let mut hasher = RandomState::with_seeds(0, 0, 0, 0).build_hasher(); for code in &self.codes { @@ -226,14 +225,12 @@ impl HasLen for EncodedInput { } impl From> for EncodedInput { - #[must_use] fn from(codes: Vec) -> Self { Self::new(codes) } } impl From<&[u32]> for EncodedInput { - #[must_use] fn from(codes: &[u32]) -> Self { Self::new(codes.to_owned()) } diff --git a/libafl/src/inputs/gramatron.rs b/libafl/src/inputs/gramatron.rs index 443ee51ad3..0c9f990861 100644 --- a/libafl/src/inputs/gramatron.rs +++ b/libafl/src/inputs/gramatron.rs @@ -43,7 +43,6 @@ pub struct GramatronInput { impl Input for GramatronInput { /// Generate a name for this input - #[must_use] fn generate_name(&self, _id: Option) -> String { let mut hasher = RandomState::with_seeds(0, 0, 0, 0).build_hasher(); for term in &self.terms { diff --git a/libafl/src/monitors/stats/perf_stats.rs b/libafl/src/monitors/stats/perf_stats.rs index 6b6a3d497d..343bc85dec 100644 --- a/libafl/src/monitors/stats/perf_stats.rs +++ b/libafl/src/monitors/stats/perf_stats.rs @@ -417,7 +417,6 @@ impl fmt::Display for ClientPerfStats { } impl Default for ClientPerfStats { - #[must_use] fn default() -> Self { Self::new() } diff --git a/libafl/src/mutators/scheduled.rs b/libafl/src/mutators/scheduled.rs index 264a17e8d9..30395e34b1 100644 --- a/libafl/src/mutators/scheduled.rs +++ b/libafl/src/mutators/scheduled.rs @@ -46,7 +46,6 @@ impl Deref for LogMutationMetadata { } } impl DerefMut for LogMutationMetadata { - #[must_use] fn deref_mut(&mut self) -> &mut [Cow<'static, str>] { &mut self.list } diff --git a/libafl/src/observers/stacktrace.rs b/libafl/src/observers/stacktrace.rs index c379db4bce..456a31120f 100644 --- a/libafl/src/observers/stacktrace.rs +++ b/libafl/src/observers/stacktrace.rs @@ -189,7 +189,6 @@ impl<'a> BacktraceObserver<'a> { impl ObserverWithHashField for BacktraceObserver<'_> { /// Gets the hash value of this observer. - #[must_use] fn hash(&self) -> Option { *self.hash.as_ref() } @@ -345,7 +344,6 @@ impl AsanBacktraceObserver { impl ObserverWithHashField for AsanBacktraceObserver { /// Gets the hash value of this observer. - #[must_use] fn hash(&self) -> Option { self.hash } diff --git a/libafl/src/stages/push/mod.rs b/libafl/src/stages/push/mod.rs index 92855ee6e7..bc17b55ded 100644 --- a/libafl/src/stages/push/mod.rs +++ b/libafl/src/stages/push/mod.rs @@ -238,7 +238,6 @@ static mut PUSH_STAGE_ADAPTER_ID: usize = 0; pub static PUSH_STAGE_ADAPTER_NAME: &str = "pushstageadapter"; impl Named for PushStageAdapter { - #[must_use] fn name(&self) -> &Cow<'static, str> { &self.name } diff --git a/libafl_bolts/src/ownedref.rs b/libafl_bolts/src/ownedref.rs index d15046d352..1c7c6bc905 100644 --- a/libafl_bolts/src/ownedref.rs +++ b/libafl_bolts/src/ownedref.rs @@ -230,7 +230,6 @@ where } impl AsRef<[u8]> for OwnedRef<'_, [u8]> { - #[must_use] fn as_ref(&self) -> &[u8] { match self { OwnedRef::RefRaw(r, _) => unsafe { (*r).as_ref().unwrap() }, @@ -244,7 +243,6 @@ impl AsRef for OwnedRef<'_, T> where T: Sized, { - #[must_use] fn as_ref(&self) -> &T { match self { OwnedRef::RefRaw(r, _) => unsafe { (*r).as_ref().unwrap() }, @@ -258,7 +256,6 @@ impl IntoOwned for OwnedRef<'_, T> where T: Sized + Clone, { - #[must_use] fn is_owned(&self) -> bool { match self { OwnedRef::RefRaw(..) | OwnedRef::Ref(_) => false, @@ -266,7 +263,6 @@ where } } - #[must_use] fn into_owned(self) -> Self { match self { OwnedRef::RefRaw(r, _) => { @@ -361,7 +357,6 @@ where } impl AsRef for OwnedRefMut<'_, T> { - #[must_use] fn as_ref(&self) -> &T { match self { OwnedRefMut::RefRaw(r, _) => unsafe { r.as_ref().unwrap() }, @@ -372,7 +367,6 @@ impl AsRef for OwnedRefMut<'_, T> { } impl AsMut for OwnedRefMut<'_, T> { - #[must_use] fn as_mut(&mut self) -> &mut T { match self { OwnedRefMut::RefRaw(r, _) => unsafe { r.as_mut().unwrap() }, @@ -386,7 +380,6 @@ impl IntoOwned for OwnedRefMut<'_, T> where T: Sized + Clone, { - #[must_use] fn is_owned(&self) -> bool { match self { OwnedRefMut::RefRaw(..) | OwnedRefMut::Ref(_) => false, @@ -394,7 +387,6 @@ where } } - #[must_use] fn into_owned(self) -> Self { match self { OwnedRefMut::RefRaw(r, _) => unsafe { @@ -592,7 +584,6 @@ impl IntoOwned for OwnedSlice<'_, T> where T: Sized + Clone, { - #[must_use] fn is_owned(&self) -> bool { match self.inner { OwnedSliceInner::RefRaw(..) | OwnedSliceInner::Ref(_) => false, @@ -600,7 +591,6 @@ where } } - #[must_use] fn into_owned(self) -> Self { match self.inner { OwnedSliceInner::RefRaw(rr, len, _) => Self { @@ -787,7 +777,6 @@ impl IntoOwned for OwnedMutSlice<'_, T> where T: Sized + Clone, { - #[must_use] fn is_owned(&self) -> bool { match self.inner { OwnedMutSliceInner::RefRaw(..) | OwnedMutSliceInner::Ref(_) => false, @@ -795,7 +784,6 @@ where } } - #[must_use] fn into_owned(self) -> Self { let vec = match self.inner { OwnedMutSliceInner::RefRaw(rr, len, _) => unsafe { @@ -987,7 +975,6 @@ impl IntoOwned for OwnedMutSizedSlice<'_, T, N> where T: Sized + Clone, { - #[must_use] fn is_owned(&self) -> bool { match self.inner { OwnedMutSizedSliceInner::RefRaw(..) | OwnedMutSizedSliceInner::Ref(_) => false, @@ -995,7 +982,6 @@ where } } - #[must_use] fn into_owned(self) -> Self { let slice: Box<[T; N]> = match self.inner { OwnedMutSizedSliceInner::RefRaw(rr, _) => unsafe { Box::from((*rr).clone()) }, @@ -1116,7 +1102,6 @@ where } impl AsRef for OwnedPtr { - #[must_use] fn as_ref(&self) -> &T { match self { OwnedPtr::Ptr(p) => unsafe { p.as_ref().unwrap() }, @@ -1129,7 +1114,6 @@ impl IntoOwned for OwnedPtr where T: Sized + Clone, { - #[must_use] fn is_owned(&self) -> bool { match self { OwnedPtr::Ptr(_) => false, @@ -1137,7 +1121,6 @@ where } } - #[must_use] fn into_owned(self) -> Self { match self { OwnedPtr::Ptr(p) => unsafe { OwnedPtr::Owned(Box::new(p.as_ref().unwrap().clone())) }, @@ -1206,7 +1189,6 @@ where } impl AsRef for OwnedMutPtr { - #[must_use] fn as_ref(&self) -> &T { match self { OwnedMutPtr::Ptr(p) => unsafe { p.as_ref().unwrap() }, @@ -1228,7 +1210,6 @@ impl IntoOwned for OwnedMutPtr where T: Sized + Clone, { - #[must_use] fn is_owned(&self) -> bool { match self { OwnedMutPtr::Ptr(_) => false, @@ -1236,7 +1217,6 @@ where } } - #[must_use] fn into_owned(self) -> Self { match self { OwnedMutPtr::Ptr(p) => unsafe { diff --git a/libafl_cc/src/ar.rs b/libafl_cc/src/ar.rs index 91d076a7a2..fefc43afc0 100644 --- a/libafl_cc/src/ar.rs +++ b/libafl_cc/src/ar.rs @@ -215,7 +215,6 @@ impl ToolWrapper for ArWrapper { impl Default for ArWrapper { /// Create a new Clang Wrapper - #[must_use] fn default() -> Self { Self::new() } diff --git a/libafl_cc/src/clang.rs b/libafl_cc/src/clang.rs index a16d25e8e8..2e5239c250 100644 --- a/libafl_cc/src/clang.rs +++ b/libafl_cc/src/clang.rs @@ -545,7 +545,6 @@ impl CompilerWrapper for ClangWrapper { } impl Default for ClangWrapper { /// Create a new Clang Wrapper - #[must_use] fn default() -> Self { Self::new() } diff --git a/libafl_cc/src/libtool.rs b/libafl_cc/src/libtool.rs index 3398c819f9..1d3a07e892 100644 --- a/libafl_cc/src/libtool.rs +++ b/libafl_cc/src/libtool.rs @@ -251,7 +251,6 @@ impl ToolWrapper for LibtoolWrapper { impl Default for LibtoolWrapper { /// Create a new Clang Wrapper - #[must_use] fn default() -> Self { Self::new() }